[theme-reviewers] Something we need to check for 3.4 appearance -> background

Edward Caissie edward.caissie at gmail.com
Mon Jun 11 18:42:58 UTC 2012


A good point to ponder ... and something to add to this as it really does
come down to author aesthetics and prerogatives: should we be once again
looking to add a "child-theme-compatible" theme tag?


Cais.


On Mon, Jun 11, 2012 at 2:33 PM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:

> Because of the coding of how appearance -> background works in 3.4 there
> is going to be a problem with 'parent' themes setting default images and
> colors to their theme. (probably just images from what I read)
>
> The problem:
>
> If a parent theme sets an image as a default in the $args,  it will
> forever then be required to use the appearance -> background
>
> Why:
>
> Order of execution, even if you remove the background image and color from
> the background -> appearance it still sets background-image: none;  even
> after cleared.
>
> What this does?
>
> This makes it so that any image set from the style.css either child theme
> or parent theme or even plugin will be ignored completely.
>
> -------
>
> What we need to look for.
>
> If the theme in question ever wants to have child themes associated with
> it, then the main theme must *not* set defaults in the $args in 3.4
>
> Since we want everyone to be child theme capable.   Then if any defaults
> are set in the parent theme they need to be removed or child themes simply
> will not work when setting a new image for that child theme.
>
>
> ---
>
> This might change if the logic changes before release, but this is how it
> is right now.  according to:
>
> http://core.trac.wordpress.**org/ticket/20448<http://core.trac.wordpress.org/ticket/20448>
>
>
>
>
> ______________________________**_________________
> theme-reviewers mailing list
> theme-reviewers at lists.**wordpress.org<theme-reviewers at lists.wordpress.org>
> http://lists.wordpress.org/**mailman/listinfo/theme-**reviewers<http://lists.wordpress.org/mailman/listinfo/theme-reviewers>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120611/ffcfe927/attachment.htm>


More information about the theme-reviewers mailing list