[theme-reviewers] Child Themes

Simon Prosser pross at pross.org.uk
Mon Jul 9 19:22:48 UTC 2012


Cais, your patch looks for TemplateVersion, but TC looks for Template
Version is this intended? Which is the right one lol?

On 9 July 2012 16:56, Edward Caissie <edward.caissie at gmail.com> wrote:
> PS: That really doesn't read right; I think I need more coffee.
>
>
> Cais.
>
>
>
> On Mon, Jul 9, 2012 at 11:55 AM, Edward Caissie <edward.caissie at gmail.com>
> wrote:
>>
>> I just read your comment. Thanks for the support ... and testing!
>> Writing the code was easy enough but testing it out where I am right ...
>> now not so much.
>>
>>
>> Cais.
>>
>>
>>
>> On Mon, Jul 9, 2012 at 11:47 AM, Amy Hendrix <sabreuse at gmail.com> wrote:
>>>
>>> Commented on the ticket. Thanks for updating!
>>>
>>> On Mon, Jul 9, 2012 at 10:56 AM, Edward Caissie
>>> <edward.caissie at gmail.com> wrote:
>>> > Alright ... updated patch added to ticket. Support (and testing) from
>>> > the
>>> > WPTRT would probably help to get this further along than what it has.
>>> >
>>> >
>>> > Cais.
>>> >
>>> >
>>> >
>>> > On Mon, Jul 9, 2012 at 10:45 AM, Edward Caissie
>>> > <edward.caissie at gmail.com>
>>> > wrote:
>>> >>
>>> >> I think I have the new/updated patch ready ... I'll get it updated
>>> >> shortly.
>>> >>
>>> >>
>>> >> Cais.
>>> >>
>>> >>
>>> >>
>>> >> On Mon, Jul 9, 2012 at 10:02 AM, Amy <sabreuse at gmail.com> wrote:
>>> >>>
>>> >>> Yeah, I hear you there!
>>> >>>
>>> >>>
>>> >>> On Jul 9, 2012, at 9:37 AM, Edward Caissie <edward.caissie at gmail.com>
>>> >>> wrote:
>>> >>>
>>> >>> @Amy - I would have really liked to see version checking get in when
>>> >>> I
>>> >>> proposed it back at 3.1!?!
>>> >>>
>>> >>> I'll try to get a look at this week though ...
>>> >>>
>>> >>>
>>> >>> Cais.
>>> >>>
>>> >>>
>>> >>> On Sun, Jul 8, 2012 at 2:49 PM, Amy Hendrix <sabreuse at gmail.com>
>>> >>> wrote:
>>> >>>>
>>> >>>> @Cais, I'd really (REALLY) like to see version-check get in to 3.5,
>>> >>>> if
>>> >>>> you're interested in updating the patch to work with WP_Theme. It
>>> >>>> might be easier to get it in now while they're still closing random
>>> >>>> small bugs, rather than waiting until after the scope has been set.
>>> >>>>
>>> >>>> On Sun, Jul 8, 2012 at 10:36 AM, Edward Caissie
>>> >>>> <edward.caissie at gmail.com> wrote:
>>> >>>> > @Emil - As Otto pointed out he was the first one to place a
>>> >>>> > Child-Theme in
>>> >>>> > the repository ... and the reason I was able to add the two I
>>> >>>> > currently have
>>> >>>> > there. Thanks.
>>> >>>> >
>>> >>>> > Also, I still need to get back to reviewing those patches. I
>>> >>>> > believe
>>> >>>> > the new
>>> >>>> > WP_Theme class will affect how they might be implemented now.
>>> >>>> > Otherwise,
>>> >>>> > we're going to need more than "that's neat" to get the buy-in we
>>> >>>> > need
>>> >>>> > from
>>> >>>> > the devs to have them committed.
>>> >>>> >
>>> >>>> >
>>> >>>> > Cais.
>>> >>>> >
>>> >>>> >
>>> >>>> >
>>> >>>> > On Sun, Jul 8, 2012 at 2:07 AM, Emil Uzelac <emil at themeid.com>
>>> >>>> > wrote:
>>> >>>> >>
>>> >>>> >> Color is fantastic, great choice for sure. Oh sorry I didn't know
>>> >>>> >> about
>>> >>>> >> that. Cool now we know.
>>> >>>> >>
>>> >>>> >> I wasn't aware of the button at all and it's very useful.
>>> >>>> >>
>>> >>>> >> Emil
>>> >>>> >>
>>> >>>> >> On Sun, Jul 8, 2012 at 12:52 AM, Otto <otto at ottodestruct.com>
>>> >>>> >> wrote:
>>> >>>> >>>
>>> >>>> >>> On Sun, Jul 8, 2012 at 12:45 AM, Emil Uzelac <emil at themeid.com>
>>> >>>> >>> wrote:
>>> >>>> >>> > P.S. Cais is the very first author with the Child Theme in
>>> >>>> >>> > repository
>>> >>>> >>> > as
>>> >>>> >>> > well.
>>> >>>> >>>
>>> >>>> >>> Actually, that would be me, via Matt's account. :)
>>> >>>> >>>
>>> >>>> >>> The first child theme in was
>>> >>>> >>> http://wordpress.org/extend/themes/mazeld, because I was testing
>>> >>>> >>> things. It is.. not a good example to learn from. I was new to
>>> >>>> >>> .org.
>>> >>>> >>> Sorry. :(
>>> >>>> >>>
>>> >>>> >>> I'll fix it up and make it not so horrible, one of these days.
>>> >>>> >>> The
>>> >>>> >>> random image thing in the header is kinda neat though. So, you
>>> >>>> >>> know,
>>> >>>> >>> there is that. ;)
>>> >>>> >>>
>>> >>>> >>> -Otto
>>> >>>> >>> _______________________________________________
>>> >>>> >>> theme-reviewers mailing list
>>> >>>> >>> theme-reviewers at lists.wordpress.org
>>> >>>> >>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >>>> >>
>>> >>>> >>
>>> >>>> >>
>>> >>>> >> _______________________________________________
>>> >>>> >> theme-reviewers mailing list
>>> >>>> >> theme-reviewers at lists.wordpress.org
>>> >>>> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >>>> >>
>>> >>>> >
>>> >>>> >
>>> >>>> > _______________________________________________
>>> >>>> > theme-reviewers mailing list
>>> >>>> > theme-reviewers at lists.wordpress.org
>>> >>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >>>> >
>>> >>>> _______________________________________________
>>> >>>> theme-reviewers mailing list
>>> >>>> theme-reviewers at lists.wordpress.org
>>> >>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >>>
>>> >>>
>>> >>> _______________________________________________
>>> >>> theme-reviewers mailing list
>>> >>> theme-reviewers at lists.wordpress.org
>>> >>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >>>
>>> >>>
>>> >>> _______________________________________________
>>> >>> theme-reviewers mailing list
>>> >>> theme-reviewers at lists.wordpress.org
>>> >>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >>>
>>> >>
>>> >
>>> >
>>> > _______________________________________________
>>> > theme-reviewers mailing list
>>> > theme-reviewers at lists.wordpress.org
>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> >
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>



-- 
My Blog: http://pross.org.uk/
Plugins : http://pross.org.uk/plugins/
Themes: http://wordpress.org/extend/themes/profile/pross


More information about the theme-reviewers mailing list