[theme-reviewers] Theme fail at submission for conditional code

[Chip Bennett]

I'm guessing that no ticket was created in this case. :)

Usually conditional wrappers pass through the upload script. Otto/Pross:
any idea?

Mel: note that, as of WordPress 3.4, backward compatibility is only
recommended to WordPress 3.3 - though 3.2 remains optional.

Chip

On Wed, Jul 4, 2012 at 2:02 PM, Konstantin Obenland
<konstantin at obenland.it>wrote:

> Hi Mel,
>
> these kind of things are usually best discussed in-ticket.
>
> Thanks,
> Konstantin
>
> On Jul 4, 2012, at 9:00 PM, esmi at quirm dot net wrote:
>
> > Theme: Scrapbook 5.4
> >
> > Reason:
> > REQUIRED: add_contextual_help found in the file theme-options.php.
> Deprecated since version 3.3. Use get_current_screen()->add_help_tab()
> instead.
> >
> > add_contextual_help is being used in a conditional to provide backwards
> compatibility based on a snippet from Twenty Eleven.
> >
> > =========================
> > if ( method_exists( $screen, 'add_help_tab' ) ) {
> >       // WordPress 3.3
> >       $screen->add_help_tab( array(
> >               'title' => __( 'Overview', 'scrapbook' ),
> >               'id' => 'theme-options-help',
> >               'content' => $help,
> >               )
> >       );
> >       $screen->set_help_sidebar( $sidebar );
> > }
> > else add_contextual_help( $screen, $help . $sidebar ); // WordPress 3.2
> > =========================
> >
> > Will get_current_screen()->add_help_tab() work in 3.2?
> >
> > Mel
> > --
> > http://quirm.net
> > http://blackwidows.co.uk
> >
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120704/7817b01a/attachment.htm>