[theme-reviewers] unable to upload please advice

Thu Aug 23 11:14:17 UTC 2012

I consider not making things backwards compatible since we want people to upgrade their WordPress to stay current with the latest bug fixes/exploit fixes as well.

From: Petar Genev 
Sent: Thursday, August 23, 2012 4:04 AM
To: theme-reviewers at lists.wordpress.org 
Subject: Re: [theme-reviewers] unable to upload please advice

Ok so let me know what to do and I will do it. I would prefer keeping in mind the old wp versions but if you say you want only the last one this is what I will do.

Thanks :-)

Petar

On Thu, Aug 23, 2012 at 11:49 AM, Bryan Hadaway <bhadaway at gmail.com> wrote:

  I remember now reading about it, here it is:

  http://codex.wordpress.org/Theme_Review#Code_Quality

  So it's sort of a yes and no situation. 

  Bryan Phillip Hadaway

  Web & Graphic Designer
  calmestghost.com
  bhadaway at gmail.com

  Socialize: Facebook | Twitter | LinkedIn | Google+

  On Thu, Aug 23, 2012 at 1:14 AM, Emil Uzelac <emil at themeid.com> wrote:

    Many Themes, including Twenty Eleven use backward compatibility, this isn't anything out of the ordinary :) Not sure what the codes are and this is also something Otto would need to see as well. 

    It's entirely up to you, to wait awhile or re-submit without them.

    Emil

    On Thu, Aug 23, 2012 at 3:02 AM, Petar Genev <petar.genev at gmail.com> wrote:

      Hi,

      Yes. If possible I'd like to support the 3.3. and 3.4 versions as well. If not I will move to the new functions and support the latest version of WP only.

      Let me know how to proceed.

      Thanks! :-)

      Peter 

      On Thu, Aug 23, 2012 at 10:57 AM, Emil Uzelac <emil at themeid.com> wrote:

        Hi Petar, 

        So this is for backward compatibility only, I would leave this for Otto (when time permits).

        Thanks,
        Emil

        On Wed, Aug 22, 2012 at 11:26 PM, Petar Genev <petar.genev at gmail.com> wrote:

          Hi there,

          I am trying to upload a theme via http://wordpress.org/extend/themes/upload/
          I get the following two errors:

            a.. REQUIRED: add_contextual_help found in the file theme-options.php. Deprecated since version 3.3. Use get_current_screen()->add_help_tab() instead. 
            b.. RECOMMENDED: get_current_theme found in the file theme-options.php. Deprecated since version 3.4. Use wp_get_theme() instead. 
          I do not consider those two as errors because in the code I make an IF statement that checks if the new function exists and if it does not it would call the old one. This is how I make sure I use the new function if the wordpress installation is new version and use the old function on old wp installations. 
          I can easily use only the new functions but then my theme will not work fine on old versions of WP which I'd like my theme to support. By old versions I mean 3.3 and 3.4.

          For example:
          <?php $theme_name = function_exists( 'wp_get_theme' ) ? wp_get_theme() : get_current_theme(); ?>

          I think the theme checker finds the old function as a text in the codes and rises the errors without following the logic in the IF statements.

          Please tell me what can I do so I can upload my theme?

          Petar

          _______________________________________________
          theme-reviewers mailing list
          theme-reviewers at lists.wordpress.org
          http://lists.wordpress.org/mailman/listinfo/theme-reviewers

        _______________________________________________
        theme-reviewers mailing list
        theme-reviewers at lists.wordpress.org
        http://lists.wordpress.org/mailman/listinfo/theme-reviewers

      _______________________________________________
      theme-reviewers mailing list
      theme-reviewers at lists.wordpress.org
      http://lists.wordpress.org/mailman/listinfo/theme-reviewers

    _______________________________________________
    theme-reviewers mailing list
    theme-reviewers at lists.wordpress.org
    http://lists.wordpress.org/mailman/listinfo/theme-reviewers

  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers

--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120823/ad50722a/attachment.htm>