[theme-reviewers] BuddyPress add_theme_support

Fri Aug 10 22:22:29 UTC 2012

Tags are also returned with the http://codex.wordpress.org/Function_Reference/wp_get_theme  wp_get_theme() function, so it’s easily accessible by buddypress to check for.

Instead of creating more levels of indirection that denote the same thing, consistency should be thought of in most instances, if something is already utilized it should be continued to be used.

From: Chip Bennett 
Sent: Friday, August 10, 2012 3:13 PM
To: theme-reviewers at lists.wordpress.org 
Subject: Re: [theme-reviewers] BuddyPress add_theme_support

I'm I'm understanding Paul correctly, I would support the add_theme_support() method. That seems to be the current "WordPress" way to register support for various features. 

I would be less confident in relying on the style.css Tags: header tag.

On Fri, Aug 10, 2012 at 4:32 PM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:

  You already have a buddypress tag, why not check if the tag exists and use that instead of creating yet another entity ?

  From: Paul Gibbs 
  Sent: Friday, August 10, 2012 2:29 PM
  To: theme-reviewers at lists.wordpress.org 
  Subject: Re: [theme-reviewers] BuddyPress add_theme_support

  Let me explain a bit more, I think your advice would be appreciated. 

  Right now, BP's default theme does add_theme_support('buddypress'), but we don't use it for anything. At a point in the future -- most probably 1.7, our next major release -- we'll be implementing called a "theme compatibility layer". If anyone knows how the templating in bbPress 2 works, it'll be almost identical. For those who don't, in a nutshell, BP will ship with a very lightweight very minimal set of templates. This is NOT a real theme. With some voodoo magic, those template parts will allow BP to work on any WordPress theme out of the box (just like bbPress).

  This is a pretty drastic change, so we will need to maintain backwards compatibility with existing themes. There are nuances and edge-cases about how we think we will do this, but excluding those for the sake of brevity, the logic will work like this:

    a.. If the theme or its parent does current_theme_supports('buddypress'), BP will assume the theme has ALL of the templates -- and so won't load the theme compatibility. The theme is saying to BP, "don't worry, I've got this covered". 
    b.. Otherwise, if certain BP-specific template files exist in the theme, we will not load the theme compatibility. (for old/existing BP themes that don't do add_theme_support). 
    c.. Otherwise, the theme compatibility layer will be loaded.
  Checking current_theme_supports is a nicer approach rather than checking for the presences of template files in a theme, even if we cache the result of the file_exists() call. This is my motivation for reaching out and seeing if this could be added as a recommendation for BP theme reviews.

  -- 
  Paul Gibbs 

  On Monday, 6 August 2012 at 16:57, George Mamadashvili wrote:

    I think BuddyPress theme changes are going to be implemented in 1.7, here's more infor from Paul -  http://bpdevel.wordpress.com/2012/08/03/group-templates-in-buddypress-1-7/

    On Mon, Aug 6, 2012 at 8:08 AM, Chip Bennett <chip at chipbennett.net> wrote:

      Absolutely. 

      When do you anticipate this change? Is this something that can be added to the WordPress 3.5-related guidelines revisions, or will we need to implement sooner than that?

      Thanks,

      Chip

      On Sun, Aug 5, 2012 at 11:00 PM, Paul Gibbs <paul at byotos.com> wrote:

        Hi all, 

        I'm one of the core developers on the BuddyPress plugin. Some changes we have planned in the pipeline for BuddyPress will affect the way BuddyPress interacts with themes. To help this, it would be ideal if all BuddyPress themes on WordPress.org had to have add_theme_support( 'buddypress' ) in its functions.php. Please could this be added as a theme review mandatory requirement for BuddyPress themes? 

        -- 
        Paul Gibbs 

        _______________________________________________
        theme-reviewers mailing list
        theme-reviewers at lists.wordpress.org
        http://lists.wordpress.org/mailman/listinfo/theme-reviewers

      _______________________________________________
      theme-reviewers mailing list
      theme-reviewers at lists.wordpress.org
      http://lists.wordpress.org/mailman/listinfo/theme-reviewers

    _______________________________________________
    theme-reviewers mailing list
    theme-reviewers at lists.wordpress.org
    http://lists.wordpress.org/mailman/listinfo/theme-reviewers

------------------------------------------------------------------------------

  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers

  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers

--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120810/34dff57d/attachment.htm>