[theme-reviewers] Prefixing Functions (for libraries)

Chip Bennett chip at chipbennett.net
Mon Jul 25 13:19:14 UTC 2011


The only valid exception (or, more properly: corollary) to the rule that I
know of would be function declarations inside of classes - in which case,
the Class itself must be properly prefixed.

Chip

On Mon, Jul 25, 2011 at 8:13 AM, Edward Caissie <edward.caissie at gmail.com>wrote:

> It is simply a better safe than sorry approach. I cannot think of any
> function that should not be properly prefixed with an appropriate namespace,
> especially those related to a specific theme.
>
>
> Cais.
>
>
>
> On Mon, Jul 25, 2011 at 7:41 AM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> Why would a library be exempted? Its functions wind up in the run-time
>> just the same as any other function, and thus would have the same
>> opportunity for naming conflicts.
>>
>> (And in this case in particular, the non-prefixed function names are
>> sufficiently generic as to have a high chance of such conflicts:
>> remove_generator_link(), include_all(), get_profile_uri(),
>> add_lightbox_rel(), etc.)
>>
>> Chip
>>
>> On Mon, Jul 25, 2011 at 4:31 AM, Vicky Arulsingam <
>> vicky.arulsingam at gmail.com> wrote:
>>
>>> If a theme is using a library of functions, are those functions exempt
>>> from the "functions must be prefixed with the theme slug or an appropriate
>>> variant" rule?
>>>
>>> The theme I'm reviewing (
>>> http://themes.svn.wordpress.org/evolve/1.2.6/library/) has a library
>>> section that contains some prefixed functions while others aren't.
>>>
>>>
>>> -----
>>> Vicky Arulsingam
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110725/af3d6df7/attachment.htm>


More information about the theme-reviewers mailing list