[theme-reviewers] [WordPress Themes] #2478: THEME: Black Queen- 1.3

[Philip M. Hofer (Frumph)]

Another place is here:
<?php wp_enqueue_script('black-queen', get_stylesheet_directory_uri() . '/js/black-queen.js'); // Include black-queen script ?>



That should be get_template_directory_uri() as well.

As said, stylesheet = child theme, template = parent theme.   If a user was using a child theme, that function would not work (unless its in the child theme)

So you should go over your entire theme and check to make sure your using the correct usage of get_?_directory_uri()



  ----- Original Message ----- 
  From: Ford Mon 
  To: theme-reviewers at lists.wordpress.org 
  Sent: Monday, January 10, 2011 11:04 AM
  Subject: Re: [theme-reviewers] [WordPress Themes] #2478: THEME: Black Queen- 1.3


   To Frumph


  You wrote the requirement:  - Stylesheets using @import are alright, the wp_enqueue_style requirement
   is if it's hardcoded instead of enqueued, while inside of an -IF LTE IE
   statement and such is alright to hardcode as long as the proper
   directory_uri is used.
  Why to use wp_enqueue_style() if we have 1CSS ? Please elaborate


  Unfortunately get_stylesheet_directory_uri(); is not it, it's
   get_template_directory_uri() which needs to be fixed before being
   accepted.  If using get_stylesheet_directory_uri() and a user is using a
   child-theme it will check the css/ of that child theme and not where it's
   located in the main template. Please explain what should I fix. I do not have a child theme. 




  get_stylesheet_directory(_uri)() will check the childtheme first, if no
   childtheme it will use the main parent theme.
   get_template_directory(_uri)() will always check the parent theme  The previous reviewer stated that there is no need in get_stylesheet_directory(_uri) so I took it out. Guys, could you come to the consensus what's wrong in my theme? 




  On Sun, Jan 9, 2011 at 6:25 PM, WordPress Themes <theme-reviewers at lists.wordpress.org> wrote:

    #2478: THEME: Black Queen - 1.3
    ------------------------------+-------------------------------
     Reporter:  themesfromrobin  |     Owner:  joshstauffer

         Type:  theme            |    Status:  closed
    Resolution:  not-approved     |  Keywords:  theme-black-queen,
    ------------------------------+-------------------------------
    Changes (by Frumph):

     * status:  assigned => closed
     * resolution:   => not-approved


    Comment:

     - Stylesheets using @import are alright, the wp_enqueue_style requirement
     is if it's hardcoded instead of enqueued, while inside of an -IF LTE IE
     statement and such is alright to hardcode as long as the proper
     directory_uri is used.

     Unfortunately get_stylesheet_directory_uri(); is not it, it's
     get_template_directory_uri() which needs to be fixed before being
     accepted.  If using get_stylesheet_directory_uri() and a user is using a
     child-theme it will check the css/ of that child theme and not where it's
     located in the main template.

     get_stylesheet_directory(_uri)() will check the childtheme first, if no
     childtheme it will use the main parent theme.
     get_template_directory(_uri)() will always check the parent theme

     Required's
     => adjust all of the get_stylesheet/template(_uri)() references to match
     appropriate locations to where the files are
     => fix the missing  px in the #content .archive-meta

     ^ Recommendations above stand.

    --
    Ticket URL: <http://themes.trac.wordpress.org/ticket/2478#comment:3>

    WordPress Themes <http://themes.trac.wordpress.org/>
    WordPress.org Theme Directory Reviews





------------------------------------------------------------------------------


  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110110/50f231b4/attachment-0001.htm>