[theme-reviewers] @Otto: Theme Uploader False-Positive

Otto otto at ottodestruct.com
Wed Feb 23 18:12:11 UTC 2011


The uploader script is running an older outdated version of the theme
checks. I need to resync them.

-Otto



On Wed, Feb 23, 2011 at 11:36 AM, Chip Bennett <chip at chipbennett.net> wrote:
> Strangely, I didn't get the error in Theme-Check, but only in the uploader
> script.
> I'll update Theme Check to trunk, and report back.
> Chip
>
> On Wed, Feb 23, 2011 at 11:17 AM, Simon Prosser <pross at pross.org.uk> wrote:
>>
>> On 02/23/11 16:56, Chip Bennett wrote:
>> > I noticed a false-positive in the Theme Uploader script:
>> >
>> > Results of Automated Theme Scanning: Fail
>> >
>> >    - WARNING: Found *eval* in the PHP files. This is not allowed.
>> >
>> >
>> > I don't use eval() anywhere in Oenology. I do, however, use the term
>> > "evaluate"/"evaluated" in PHP comments. I could find no other examples
>> > of
>> > "eval" appearing anywhere in any of the Theme template files.
>> Looks like the eval() regex needs updating, Chip can you update
>> themecheck to latest trunk and test your theme again? ive updated the
>> regex.
>> FYI it is now /(?<![_|a-z0-9])eval\s?\(/
>>
>> --
>> My Blog: http://www.pross.org.uk/
>> Plugins: http://www.pross.org.uk/plugins/
>> Themes : http://wordpress.org/extend/themes/profile/pross
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


More information about the theme-reviewers mailing list