[theme-reviewers] A few issues to look out for

[Chip Bennett]

Hmm... I don't think I've yet seen a Theme that explicitly handles
tweetbacks. (Honestly, I didn't even realize such a comment type existed.)

Chip

On Wed, Apr 27, 2011 at 2:16 PM, Justin Tadlock <justin at justintadlock.com>wrote:

> Here's a few things we should be on the lookout for when reviewing themes
> that I thought I'd bring up.
>
> The use of the_post_thumbnail() with the_content() can sometimes be a
> problem.  If a user places the image within the post content (at the
> beginning of the post) and sets the same image as the "feature image," it
> creates a duplicate image issue.  Some themes' designs are meant to handle
> this while others aren't.
>
> Some themes have a comments callback function where they don't recognize
> comment types other than 'comment', 'pingback', and 'trackback'.   This is
> also the case in the TwentyTen theme.  If you look at its switch statement,
> you'll notice it doesn't give a 'default' case.  It should be corrected to
> handle all comment types (e.g., tweetbacks).
>
> Loading JS and CSS on all pages of the admin.  Sometimes, themes hook their
> theme settings page JavaScript and Stylesheet to the 'admin_init' hook or
> something similar.  This should only be loaded on the the theme settings
> page.  If using the add_theme_page() function, a hook is created just for
> that page.  A better hook would probably be
> 'load-appearance_page_$pagename'.
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110426/465767c3/attachment.htm>