[theme-reviewers] Theme review completed

Tue Apr 19 23:11:18 UTC 2011

I've completed another theme review tonight and would like to review another please tomorrow taking the feedback on board of extra things I should be looking for. Again happy either BuddyPress or WordPress.

http://themes.trac.wordpress.org/ticket/3487 was one did tonight.

Regards,
Tammie Lister

On Tuesday, 19 April 2011 at 23:58, theme-reviewers-request at lists.wordpress.org wrote: 
> Send theme-reviewers mailing list submissions to
> theme-reviewers at lists.wordpress.org
> 
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> or, via email, send a message with subject or body 'help' to
> theme-reviewers-request at lists.wordpress.org
> 
> You can reach the person managing the list at
> theme-reviewers-owner at lists.wordpress.org
> 
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of theme-reviewers digest..."
> 
> 
> Today's Topics:
> 
>  1. Re: @smgrundy [WordPress Themes] #3563: THEME: For
>  Women-Female - 1.1 (Shawn Grundy)
>  2. Re: @smgrundy [WordPress Themes] #3563: THEME: For
>  Women-Female - 1.1 (Emil Uzelac)
>  3. After 3367 - request (rex posadas)
>  4. Re: Another ticket (Curtis McHale)
>  5. Re: Another ticket (Chip Bennett)
> 
> 
> ----------------------------------------------------------------------
> 
> Message: 1
> Date: Tue, 19 Apr 2011 14:21:38 -0700
> From: Shawn Grundy <smgrundy at live.com>
> Subject: Re: [theme-reviewers] @smgrundy [WordPress Themes] #3563:
>  THEME: For Women-Female - 1.1
> To: <theme-reviewers at lists.wordpress.org>
> Message-ID: <COL102-W23982B423D7C0CA1596795AE900 at phx.gbl>
> Content-Type: text/plain; charset="iso-8859-1"
> 
> 
> done
> 
> From: emil at themeid.com
> Date: Tue, 19 Apr 2011 15:50:22 -0500
> To: theme-reviewers at lists.wordpress.org
> Subject: Re: [theme-reviewers] @smgrundy [WordPress Themes] #3563: THEME: For Women-Female - 1.1
> 
> ----Emil Uzelac | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E: emil at themeid.com | http://themeid.com
> 
> 
> Make everything as simple as possible, but not simpler. - Albert Einstein
> 
> 
> 
> On Tue, Apr 19, 2011 at 3:49 PM, WordPress Themes <theme-reviewers at lists.wordpress.org> wrote:
> 
> 
> #3563: THEME: For Women-Female - 1.1
> 
> ------------------------+-----------------------------------
> 
>  Reporter: Stilisten | Owner: smgrundy
> 
>  Type: theme | Status: assigned
> 
> Resolution: | Keywords: theme-for-women-female
> 
> ------------------------+-----------------------------------
> 
> Changes (by emiluzelac):
> 
> 
> 
>  * owner: => smgrundy
> 
>  * status: new => assigned
> 
> 
> 
> 
> 
> Comment:
> 
> 
> 
>  @smgrundy since you reviewed first time here it is once again. This should
> 
>  be good to go as the author fixed all of the items.
> 
> 
> 
> --
> 
> Ticket URL: <http://themes.trac.wordpress.org/ticket/3563#comment:1>
> 
> WordPress Themes <http://themes.trac.wordpress.org/>
> 
> WordPress.org Theme Directory Reviews
> 
> 
> 
> 
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers 
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110419/e2e4a631/attachment-0001.htm>
> 
> ------------------------------
> 
> Message: 2
> Date: Tue, 19 Apr 2011 16:29:11 -0500
> From: Emil Uzelac <emil at themeid.com>
> Subject: Re: [theme-reviewers] @smgrundy [WordPress Themes] #3563:
>  THEME: For Women-Female - 1.1
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <BANLkTikKrPxMtJrueT+CK-pt4BfWN1nJpA at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
> 
> Thank you!
> *----*
> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
> emil at themeid.com | http://themeid.com
> Make everything as simple as possible, but not simpler. - Albert Einstein
> 
> 
> 
> On Tue, Apr 19, 2011 at 4:21 PM, Shawn Grundy <smgrundy at live.com> wrote:
> 
> >  done
> > 
> > ------------------------------
> > From: emil at themeid.com
> > Date: Tue, 19 Apr 2011 15:50:22 -0500
> > To: theme-reviewers at lists.wordpress.org
> > Subject: Re: [theme-reviewers] @smgrundy [WordPress Themes] #3563: THEME:
> > For Women-Female - 1.1
> > 
> > 
> > 
> > *----*
> > *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
> > emil at themeid.com | http://themeid.com
> > Make everything as simple as possible, but not simpler. - Albert Einstein
> > 
> > 
> > 
> > On Tue, Apr 19, 2011 at 3:49 PM, WordPress Themes <
> > theme-reviewers at lists.wordpress.org> wrote:
> > 
> > #3563: THEME: For Women-Female - 1.1
> > ------------------------+-----------------------------------
> >  Reporter: Stilisten | Owner: smgrundy
> >  Type: theme | Status: assigned
> > Resolution: | Keywords: theme-for-women-female
> > ------------------------+-----------------------------------
> > Changes (by emiluzelac):
> > 
> >  * owner: => smgrundy
> >  * status: new => assigned
> > 
> > 
> > Comment:
> > 
> >  @smgrundy since you reviewed first time here it is once again. This should
> >  be good to go as the author fixed all of the items.
> > 
> > --
> > Ticket URL: <http://themes.trac.wordpress.org/ticket/3563#comment:1>
> > WordPress Themes <http://themes.trac.wordpress.org/>
> > WordPress.org Theme Directory Reviews
> > 
> > 
> > 
> > _______________________________________________ theme-reviewers mailing
> > list theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> > 
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110419/5999840f/attachment-0001.htm>
> 
> ------------------------------
> 
> Message: 3
> Date: Tue, 19 Apr 2011 15:33:07 -0700 (PDT)
> From: rex posadas <rexposadas at yahoo.com>
> Subject: [theme-reviewers] After 3367 - request
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <969894.75830.qm at web36504.mail.mud.yahoo.com>
> Content-Type: text/plain; charset="us-ascii"
> 
> Hello, 
> 
> I just reviewed 3367, I am ready for another theme. 
> 
> username: rxn
> 
> Thank You. 
> 
> Rex
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110419/96396658/attachment-0001.htm>
> 
> ------------------------------
> 
> Message: 4
> Date: Tue, 19 Apr 2011 15:44:52 -0700
> From: Curtis McHale <curtis at curtismchale.ca>
> Subject: Re: [theme-reviewers] Another ticket
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <BANLkTi==o+EbjW9CVjQ3BOcsmrZ4MAVXaQ at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
> 
> The theme I'm reviewing has JS that detects the browser version and tells
> them to update (http://browser-update.org/). There is not a theme option to
> remove this function or information in the description.
> 
> What is the theme review stance on this feature?
> 
> There are also some list styles missing in comments. I don't think this is a
> reason for failure but should be noted and requested for update on the next
> version. Is that correct?
> 
> The theme options are strictly a page that suggests the user donate if they
> like the theme. I know that credit links are okay but I'm not sure about
> this instance.
> 
> The theme calls loop-archive.php through get_template_part but the file
> doesn't actually exist. Fortunately it defaults to loop.php but I'm
> wondering how this would be addressed. The theme works but I would think
> this should be corrected in the next version either by just using loop.php
> or by adding the file that is being called. Is that correct?
> 
> The theme doesn't support post_formats. I thought that they were supposed to
> at least declare it and support whichever they picked. I don't see this
> information on the Theme Review page so is this assumption incorrect?
> 
> Curtis McHale
> PH: 604.751.3482
> http://www.curtismchale.ca
> Linkedin: http://www.linkedin.com/in/curtismchale
> Twitter: twitter.com/curtismchale
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110419/9b218d3d/attachment-0001.htm>
> 
> ------------------------------
> 
> Message: 5
> Date: Tue, 19 Apr 2011 17:58:21 -0500
> From: Chip Bennett <chip at chipbennett.net>
> Subject: Re: [theme-reviewers] Another ticket
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <BANLkTi=Z_Qb3E9msQQNLhMAr70_Hrk5CmA at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
> 
> Comments inline...
> 
> On Tue, Apr 19, 2011 at 5:44 PM, Curtis McHale <curtis at curtismchale.ca>wrote:
> 
> > The theme I'm reviewing has JS that detects the browser version and tells
> > them to update (http://browser-update.org/). There is not a theme option
> > to remove this function or information in the description.
> > 
> > What is the theme review stance on this feature?
> 
> Incredibly annoying, but nothing prohibits it. I would *require* a mention
> of the "feature" in Theme documentation (readme.txt).
> 
> > 
> > There are also some list styles missing in comments. I don't think this is
> > a reason for failure but should be noted and requested for update on the
> > next version. Is that correct?
> 
> It depends on how egregious the style omission is. If lists within comments
> are inheriting the comment-list styling, I would fail for that. If they
> merely don't have proper indenting/bullets, I would perhaps say *required*
> in next revision.
> 
> > 
> > The theme options are strictly a page that suggests the user donate if they
> > like the theme. I know that credit links are okay but I'm not sure about
> > this instance.
> 
> Also nothing prohibiting this. But I would balk at calling such a page an
> "Options" page. You could perhaps require the page to be titled "Theme
> Documentation" (etc.) rather than "Theme Options".
> 
> > 
> > The theme calls loop-archive.php through get_template_part but the file
> > doesn't actually exist. Fortunately it defaults to loop.php but I'm
> > wondering how this would be addressed. The theme works but I would think
> > this should be corrected in the next version either by just using loop.php
> > or by adding the file that is being called. Is that correct?
> 
> That could be for Child-Theme support (allowing e.g. a Child Theme to
> include "loop-archive.php", and have it included). Due to the inherent
> callback nature of the function, this is a correct implementation.
> 
> > 
> > The theme doesn't support post_formats. I thought that they were supposed
> > to at least declare it and support whichever they picked. I don't see this
> > information on the Theme Review page so is this assumption incorrect?
> 
> Post Formats are not required to be implemented. However, if the Theme has
> custom loops for any of the Post Format types, then it is *required* to
> support the core feature.
> 
> Chip
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110419/01dbdb66/attachment.htm>
> 
> ------------------------------
> 
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> 
> 
> End of theme-reviewers Digest, Vol 11, Issue 90
> ***********************************************
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110420/c0afb47e/attachment-0001.htm>