[theme-reviewers] [WordPress Themes] #1958: THEME: GoogleChrome - 1.3.2

Sun Nov 21 00:40:18 UTC 2010

No worries on posting this to theme-reviewers. That's what the mail-list is
here for! :)

There are several ways to meet this requirement. One way is to provide some
default text when no Post Title is defined:

if ( get_the_title() ) {
     the_title();
} else {
     echo "(No Title)"; // or whatever you want to echo in place of the Post
Title
}

Another way is to add a permalink elsewhere in the Post, such as a
"Permalink" link, or making the Post Date a permalink.

By the way, every Theme that has gone through the review process will have
met this guideline. TwentyTen was approved prior to the current review
process, and I cannot vouch for its adherence to the Theme Review
Guidelines.

Chip

On Sat, Nov 20, 2010 at 6:33 PM, Genkisan <genkiemail at gmail.com> wrote:

> Hi
>
> Sorry for posting this to the theme-reviewers email list as I'm unable  to
> see the comment form at the trac ticket even after login.
> Just want to check regarding the "No Post Permalink is displayed when Post
> Title is omitted", is it to do a check and if no title, display the
> permalink? Something like
>
> if title == ''
> the_permalink
> else
> the_title
>
> Cos I'm unable to see how this is implemented in the twentyten or other
> approved themes.
>
> Thanks
> Genkisan
>
>
> On Sun, Nov 21, 2010 at 5:12 AM, WordPress Themes <
> theme-reviewers at lists.wordpress.org> wrote:
>
>> #1958: THEME: GoogleChrome - 1.3.2
>>
>> ---------------------------+------------------------------------------------
>>  Reporter:  genkisan      |      Owner:  chipbennett
>>       Type:  theme         |     Status:  closed
>> Resolution:  not-approved  |   Keywords:  theme-googlechrome,
>>
>> ---------------------------+------------------------------------------------
>> Changes (by chipbennett):
>>
>>  * status:  assigned => closed
>>  * resolution:  => not-approved
>>
>>
>> Comment:
>>
>>  '''Note: it appears that Theme Name is in violation of
>>  [https://chrome.google.com/extensions/intl/en/branding.html Google's
>>  trademark policy with respect to "Google Chrome"]. Please provide
>> evidence
>>  of permission granted for use of the "Google Chrome" name, or else re-
>>  submit Theme using a new name.'''
>>
>>  '''Theme Check'''
>>
>>  ''Recommended''
>>
>>  * Recommended: No reference to add_editor_style() was found in the theme.
>>  It is recommended that the theme implement editor styling, so as to make
>>  the editor content match the resulting post output in the theme, for a
>>  better user experience.
>>  * Recommended: No reference to add_custom_image_headerwas found in the
>>  theme. It is recommended that the theme implement this functionality if
>>  using an image for the header.
>>  * Recommended: No reference to add_custom_background() was found in the
>>  theme. If the theme uses background images or solid colors for the
>>  background, then it is recommended that the theme implement this
>>  functionality.
>>  * Recommended: No reference to post-formats was found in the theme. It is
>>  recommended that the theme implement this functionality.
>>  * Recommended: No reference to the_post_thumbnail() was found in the
>>  theme. It is recommended that the theme implement this functionality
>>  instead of using custom fields for thumbnails.
>>  * Recommended: No reference to post-thumbnails was found in the theme. If
>>  the theme has a thumbnail like functionality, it should be implemented
>>  with add_theme_support( \'post-thumbnails\' )in the functions.php file.
>>  * Recommended: could not find the file readme.txt in the theme.
>>
>>  ''Info''
>>
>>  * Info: Possible hard-coded links were found in the file footer.php.
>>   * Line 7: <a href="http://ericulous.com/2008/09/09/wp-theme-google-
>>  chrome" title="Sma
>>  * Info: At least one hard coded date was found in the file single.php.
>>  * Info: At least one hard coded date was found in the file index.php.
>>
>>  '''Required'''
>>  * Code Quality
>>   * HTML: validation error on 404.php, due to same CSS IDs used in
>>  multiple search forms.
>>  * Theme Unit Check
>>   * General
>>    * Header Menu: breaks layout when many list items cause menu to break
>>  across rows
>>   * Post With No Title
>>    * No Post Permalink is displayed when Post Title is omitted
>>
>>  '''Review Summary'''
>>
>>  Theme cannot be accepted until items listed under '''Required''' are
>>  addressed. Once these issues have been resolved, please re-submit your
>>  Theme using the uploader tool on wordpress.org/extend/themes, and a new
>>  Trac ticket will be generated.
>>
>>  Note:
>>  * Re-submitted Themes are given review priority over new Themes.
>>  * Prior to re-submitting, please ensure Theme meets all requirements in
>>  the [http://codex.wordpress.org/Theme_Review Theme Review Guidelines]
>> and
>>  the [http://codex.wordpress.org/Theme_Unit_Test Theme Unit Tests].
>>
>>  '''Responding To This Review'''
>>
>>  Theme developer questions, comments, and feedback are welcome and
>>  encouraged. Please use one of the following methods:
>>
>>  1) Leave a comment on this ticket
>>  2) Email the theme-reviewers email list
>>  3) Use the #wordpress-themes channel on irc.freenode.net
>>
>> --
>> Ticket URL: <http://themes.trac.wordpress.org/ticket/1958#comment:2>
>> WordPress Themes <http://themes.trac.wordpress.org/>
>> WordPress.org Theme Directory Reviews
>>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101120/51b6a9b0/attachment.htm>