[theme-reviewers] Theme Check Release

Simon Prosser pross at pross.org.uk
Fri Dec 31 17:55:46 UTC 2010


6pm here already had 2 cans ;) were hitting the pub soon too!

On 31 December 2010 17:53, Edward Caissie <edward.caissie at gmail.com> wrote:
> er, yep ... must be.
>
> It's 5 o'clock somewhere, right?! I think it's time to start the New Year's
> celebration since my thinking seems to be already impaired (*grin*)
>
>
> Cais.
>
> On Fri, Dec 31, 2010 at 11:39 AM, Otto <otto at ottodestruct.com> wrote:
>>
>> I think you're confusing get_footer() and wp_footer().
>>
>> get_footer() includes the footer.php file.
>>
>> wp_footer() should be *in* the footer.php file, and it basically calls
>> the wp_footer action hook.
>>
>> -Otto
>>
>>
>>
>> On Fri, Dec 31, 2010 at 10:31 AM, Simon Prosser <pross at pross.org.uk>
>> wrote:
>> > To quote the manual:
>> > Includes the footer.php template file from your current theme's
>> > directory. if a name is specified then a specialised footer
>> > footer-{name}.php will be included.
>> >
>> > wp_footer() should be used.
>> >
>> > We could add it as a deprecated though Otto?
>> >
>> > On 31 December 2010 16:25, Edward Caissie <edward.caissie at gmail.com>
>> > wrote:
>> >> Thanks, I couldn't remember any exact difference but I agree it is the
>> >> more
>> >> correct method to use the wp_footer() call.
>> >>
>> >> I'll pass along the comment.
>> >>
>> >>
>> >> Cais.
>> >>
>> >> On Fri, Dec 31, 2010 at 11:22 AM, Otto <otto at ottodestruct.com> wrote:
>> >>>
>> >>> On Fri, Dec 31, 2010 at 10:06 AM, Edward Caissie
>> >>> <edward.caissie at gmail.com> wrote:
>> >>> > @Otto, @Pross
>> >>> >
>> >>> > Just came across this on ticket:
>> >>> > http://themes.trac.wordpress.org/ticket/2382
>> >>> >
>> >>> > "REQUIRED: Could not find wp_footer. See: wp_footer
>> >>> >
>> >>> > The author used: <?php do_action('wp_footer'); ?> in place of the
>> >>> > wp_footer() call ...
>> >>>
>> >>> Well, he shouldn't do that. Tell him to change it to the wp_footer()
>> >>> call.
>> >>>
>> >>> Yes, I know that pretty much does the same thing. The difference is
>> >>> one of forward compatibility. wp_footer() might do something slightly
>> >>> different in the future. Probably not, but who knows?
>> >>>
>> >>> Never do it yourself when there exists a function to do it for you.
>> >>>
>> >>> -Otto
>> >>> _______________________________________________
>> >>> theme-reviewers mailing list
>> >>> theme-reviewers at lists.wordpress.org
>> >>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>> >>
>> >>
>> >> _______________________________________________
>> >> theme-reviewers mailing list
>> >> theme-reviewers at lists.wordpress.org
>> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > My Blog: http://www.pross.org.uk/
>> > Plugins : http://www.pross.org.uk/plugins/
>> > Themes: http://wordpress.org/extend/themes/profile/pross
>> > _______________________________________________
>> > theme-reviewers mailing list
>> > theme-reviewers at lists.wordpress.org
>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>> >
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>



-- 
My Blog: http://www.pross.org.uk/
Plugins : http://www.pross.org.uk/plugins/
Themes: http://wordpress.org/extend/themes/profile/pross


More information about the theme-reviewers mailing list