[Bb-trac] [bbPress] #1103: Profile edit input types

[bbPress]

#1103: Profile edit input types
-----------------------+----------------------------------------------------
 Reporter:  timskii    |       Owner:          
     Type:  defect     |      Status:  new     
 Priority:  normal     |   Milestone:          
Component:  Front-end  |     Version:  1.0-rc-1
 Severity:  normal     |    Keywords:  profile 
-----------------------+----------------------------------------------------
 The code in bb_profile_data_form() uses $label[2] incorrectly to assign
 type, if $label[2] is set:

 $type = isset($label[2]) ? attribute_escape( $label[2] ) : 'text';

 $type is then used to define the input type in the form HTML.
 Unfortunately, $label[2] is now being used for vcard values - 'url',
 'email', etc.

 This produces invalid HTML: input .. type="url" . Browsers are rendering
 this by assuming you meant type="text", but that's luck, not design.

 May or may not be fixed in the trunk - the line is still there, but some
 other labels have appeared elsewhere in the function. Any chance of
 assigning these keys by name, so we don't have this ongoing problem of
 remembering what array positions are used for what?

-- 
Ticket URL: <http://trac.bbpress.org/ticket/1103>
bbPress <http://bbpress.org/>
Innovative forum development