[Bb-trac] Re: [bbPress] #689: More flexible joining of topic meta tables in BB_Query class

[bbPress]

#689: More flexible joining of topic meta tables in BB_Query class
-------------------------+--------------------------------------------------
 Reporter:  sambauers    |        Owner:  mdawaffe         
     Type:  enhancement  |       Status:  new              
 Priority:  high         |    Milestone:  0.8.3 & XML-RPC  
Component:  Back-end     |      Version:  1.0-alpha (trunk)
 Severity:  major        |   Resolution:                   
 Keywords:  has-patch    |  
-------------------------+--------------------------------------------------
Comment (by sambauers):

 Deleting the meta data instead of storing "no" is not an option. When
 there is no meta data for a topic it falls back to the default resolution,
 which itself is changeable - but is set to another value.

 There are some complications with using an unquoted NULL as a value, I'm
 sure you've thought of them. The patch does explicitly limit it to an
 uppercase NULL at least.

 You are probably right about the efficiency of the LEFT JOIN proposition.
 It would probably be bad. Perhaps the proposal for a "meta_join" value
 (that defaults to a standard "JOIN") is best. I can write a patch to test
 it if you like.

 I think your correction to the patch is correct too. I didn't specifically
 test that part of the logic, but it didn't break any existing views
 either.

-- 
Ticket URL: <http://trac.bbpress.org/ticket/689#comment:2>
bbPress <http://bbpress.org/>
Innovative forum development